Re: [PATCH 4/4] snd-maestro3: Make hardware volume buttons an input device

["Ville Syrjälä" <syrjala@sci.fi>]

On Thu, Apr 22, 2010 at 09:57:42AM +0200, Hans de Goede wrote:
> On 04/21/2010 06:05 PM, Ville Syrjälä wrote:
> > On Wed, Apr 21, 2010 at 11:04:09AM -0400, Hans de Goede wrote:
> >> @@ -2524,6 +2494,42 @@ static int m3_resume(struct pci_dev *pci)
> >>   }
> >>   #endif /* CONFIG_PM */
> >>
> >> +#ifdef CONFIG_INPUT
> >> +static int __devinit snd_m3_input_register(struct snd_m3 *chip)
> >> +{
> >> +	struct input_dev *input_dev;
> >> +	int err;
> >> +
> >> +	input_dev = input_allocate_device();
> >> +	if (!input_dev)
> >> +		return -ENOMEM;
> >> +
> >> +	snprintf(chip->phys, sizeof(chip->phys), "pci-%s/input0",
> >> +		 pci_name(chip->pci));
> >
> > What's the proper format of phys? I see gameport stuff uses
> > pci%s/gameport0, ir stuff uses pci-%s/ir0. I can't immediately find any
> > other pci input things.
> >
> 
> I've no idea, I took the pci-%s/ part from other pci drivers registering
> input devices and the input0 part is based on doing:
> cat /sys/class/input/input?/phys
> 
> On my system which yields a string ending in input0 for almost all
> input devices.

Same for me. Unfortunately none start with "pci". Adding Dmitry and
linux-input in cc. Dmitry, any official statement about this phys
string?

-- 
Ville Syrjälä
syrjala@sci.fi
http://www.sci.fi/~syrjala/