From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v3 2/5(7)] OMAP1: Amstrad Delta: add a handler for processing interrupts generated by the FIQ routine Date: Mon, 26 Apr 2010 11:17:08 -0700 Message-ID: <20100426181708.GH7225@atomide.com> References: <201004150419.05038.jkrzyszt@tis.icnet.pl> <201004150426.28677.jkrzyszt@tis.icnet.pl> <20100422231725.GU18272@atomide.com> <201004230321.11269.jkrzyszt@tis.icnet.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:61304 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753497Ab0DZSRM (ORCPT ); Mon, 26 Apr 2010 14:17:12 -0400 Content-Disposition: inline In-Reply-To: <201004230321.11269.jkrzyszt@tis.icnet.pl> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Janusz Krzysztofik Cc: linux-omap@vger.kernel.org, Dmitry Torokhov , linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org, e3-hacking@earth.li * Janusz Krzysztofik [100422 18:20]: > Friday 23 April 2010 01:17:26 Tony Lindgren napisa=C5=82(a): > > * Janusz Krzysztofik [100414 19:24]: > > > This patch introduces an IRQ handler used for processing interrup= ts > > > generated by the FIQ handler when it decides there are data ready= for > > > processing. > > > > > > The handler further invokes device specific interrupt routines ba= sed on > > > an interrupt source as passed from the FIQ handler. > > > > > > It can be registered by the board as a handler for the otherwise = unused > > > 32k timer interrupt. > > > > > > Created and tested against linux-2.6.34-rc4. > > > Applies on top of PATCH v3 1/5(7), "OMAP1: Amstrad Delta: add FIQ= handler > > > for serial keyboard port interrupt processing". > > > > > > Signed-off-by: Janusz Krzysztofik > > > --- > > > v2 changes: > > > - add fiq_buffer[] declaration missing from the header file, > > > - refresh against 2.6.34-rc2. > > > v3 changes: > > > - follow Dmitry's serio cleanup suggestions here as well, > > > - follow default OMAP GPIO interrupt processing path more closely= , > > > - more optimizations and cleanups. > > > > > > arch/arm/mach-omap1/Makefile | 2 > > > arch/arm/mach-omap1/ams-delta-fiq.c | 155 ++++++++= +++++++++++++++ > > > arch/arm/mach-omap1/include/mach/ams-delta-fiq.h | 7 + > > > 3 files changed, 163 insertions(+), 1 deletion(-) > > > > > > diff -uprN git.orig/arch/arm/mach-omap1/Makefile git/arch/arm/mac= h-omap1/Makefile > > > --- git.orig/arch/arm/mach-omap1/Makefile 2010-04-14 22:35:22.000= 000000 +0200 > > > +++ git/arch/arm/mach-omap1/Makefile 2010-04-14 23:18:10.00000000= 0 +0200 > > > @@ -37,7 +37,7 @@ obj-$(CONFIG_MACH_OMAP_PALMZ71) +=3D boar > > > obj-$(CONFIG_MACH_OMAP_PALMTT) +=3D board-palmtt.o > > > obj-$(CONFIG_MACH_NOKIA770) +=3D board-nokia770.o > > > obj-$(CONFIG_MACH_AMS_DELTA) +=3D board-ams-delta.o > > > -obj-$(CONFIG_AMS_DELTA_FIQ) +=3D ams-delta-fiq-handler.o > > > +obj-$(CONFIG_AMS_DELTA_FIQ) +=3D ams-delta-fiq.o ams-delta-fiq-= handler.o > > > obj-$(CONFIG_MACH_SX1) +=3D board-sx1.o board-sx1-mmc.o > > > obj-$(CONFIG_MACH_HERALD) +=3D board-htcherald.o > > > > Do you really need a separate option for CONFIG_AMS_DELTA_FIQ? >=20 > Not really, but could we keep it for now, until the code gets a bit m= atured? >=20 > > To me it seems you can just compile it in when CONFIG_MACH_AMS_DELT= A > > is selected. >=20 > If you agree, I will change it this way with a followup patch prepare= d for the=20 > next + 1 kernel release. OK =20 > > Also, please make sure the FIQ only gets initialized for the right > > board when multiple boards are compiled in. >=20 > I believe it works this way. The ams_delta_init_fiq() routine, that s= ets up=20 > both FIQ and IRQ handlers, is invoked from the machines' init_machine= ()=20 > callback. Can I assume it won't be called for other machine types the= n? Just please check that compile works OK if you compile in other omap1 b= oards. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html