linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: akpm@linux-foundation.org
Cc: linux-input@vger.kernel.org, damjan.jov@gmail.com, rubini@cvml.unipv.it
Subject: Re: [patch 3/3] input: handle bad parity PS/2 packets in mouse drivers better
Date: Wed, 28 Apr 2010 09:45:35 -0700	[thread overview]
Message-ID: <20100428164534.GA6574@core.coreip.homeip.net> (raw)
In-Reply-To: <201004272112.o3RLCeTc020088@imap1.linux-foundation.org>

On Tue, Apr 27, 2010 at 02:12:39PM -0700, akpm@linux-foundation.org wrote:
> From: Damjan Jovanovic <damjan.jov@gmail.com>
> 
> This fixes a regression introduced in Linux 2.6.2 where mice that
> sporadically produce bad parity go crazy and start jumping around and
> clicking randomly, which never happens in any version of Windows running
> on the same hardware.  The bugzilla bug is
> https://bugzilla.kernel.org/show_bug.cgi?id=6105
> 
> The patch works by always accumulating a full PS/2 packet, then ignoring
> the packet if any byte had a bad checksum.  A month of testing it against
> an affected mouse has revealed it works perfectly in practice.
> 
> Signed-off-by: Damjan Jovanovic <damjan.jov@gmail.com>
> Cc: Alessandro Rubini <rubini@cvml.unipv.it>
> Cc: Dmitry Torokhov <dtor@mail.ru>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

Andrew, an alternative path has been merged, please drop this one.

Thanks.

-- 
Dmitry

      reply	other threads:[~2010-04-28 16:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-27 21:12 [patch 3/3] input: handle bad parity PS/2 packets in mouse drivers better akpm
2010-04-28 16:45 ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100428164534.GA6574@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=damjan.jov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=rubini@cvml.unipv.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).