linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jarod Wilson <jarod@redhat.com>
Cc: linux-media@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH] IR/imon: add proper auto-repeat support
Date: Wed, 28 Apr 2010 13:41:12 -0700	[thread overview]
Message-ID: <20100428204112.GA6663@core.coreip.homeip.net> (raw)
In-Reply-To: <20100428173700.GA14240@redhat.com>

On Wed, Apr 28, 2010 at 01:37:00PM -0400, Jarod Wilson wrote:
> Set the EV_REP bit, so reported key repeats actually make their
> way out to userspace, and fix up the handling of repeats a bit,
> routines for which are shamelessly heisted from ati_remote2.c.
>

Is it really needed? I'd expect input core handling auto-repeating
for you as long as you set EV_REP flag.

-- 
Dmitry

  reply	other threads:[~2010-04-28 20:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-28 17:37 [PATCH] IR/imon: add proper auto-repeat support Jarod Wilson
2010-04-28 20:41 ` Dmitry Torokhov [this message]
2010-04-28 21:00   ` Jarod Wilson
2010-04-30 19:06     ` [PATCH v2] " Jarod Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100428204112.GA6663@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=jarod@redhat.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).