Re: [PATCH 1/2] elantech: Report tool width when it is known

[Florian Ragwitz <rafl@debian.org>]

[-- Attachment #1: Type: text/plain, Size: 823 bytes --]

On Wed, May 05, 2010 at 02:14:25PM +0200, Éric Piel wrote:
> >From observation of the values sent from the hardware version 2, it
> seems that the first four bits of byte 1 represents the width. So we can
> report it as well. Observed values on my hardware were always between 1
> and 12, so let's use this for min and max.

Excellent. I'm quite happy to see this.

I've actually thought about reporting some kind of width based on the
"thumb" bit in the first byte. The actual width information being
available didn't occur to me for some reason.

The patch itself looks just fine to me, but it might also want to update
the elantech documentation accordingly.

See also https://patchwork.kernel.org/patch/95448/ which isn't part of
the -input tree yet.


-- 
BOFH excuse #362:
Plasma conduit breach

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]