linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Florian Ragwitz <rafl@debian.org>
Cc: "Éric Piel" <E.A.B.Piel@tudelft.nl>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: [PATCH 1/2] elantech: Report tool width when it is known
Date: Wed, 5 May 2010 10:12:53 -0700	[thread overview]
Message-ID: <20100505171253.GD7337@core.coreip.homeip.net> (raw)
In-Reply-To: <20100505165323.GG6075@perldition.org>

On Wed, May 05, 2010 at 06:53:24PM +0200, Florian Ragwitz wrote:
> On Wed, May 05, 2010 at 02:14:25PM +0200, Éric Piel wrote:
> > >From observation of the values sent from the hardware version 2, it
> > seems that the first four bits of byte 1 represents the width. So we can
> > report it as well. Observed values on my hardware were always between 1
> > and 12, so let's use this for min and max.
> 
> Excellent. I'm quite happy to see this.
> 
> I've actually thought about reporting some kind of width based on the
> "thumb" bit in the first byte. The actual width information being
> available didn't occur to me for some reason.
> 
> The patch itself looks just fine to me, but it might also want to update
> the elantech documentation accordingly.
> 
> See also https://patchwork.kernel.org/patch/95448/ which isn't part of
> the -input tree yet.
> 

It is - I folded it with the changes to the driver and it is upstream. I
left out the new 4.1 signature patch until we know better about firmware
versions, but otherwise your changes are in mainline.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2010-05-05 17:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-05 12:14 [PATCH 1/2] elantech: Report tool width when it is known Éric Piel
2010-05-05 16:39 ` Dmitry Torokhov
2010-05-05 16:58   ` Éric Piel
2010-05-05 17:13     ` Dmitry Torokhov
2010-05-05 18:00       ` Florian Ragwitz
2010-05-05 18:09         ` Dmitry Torokhov
2010-05-05 18:13           ` Éric Piel
2010-05-05 16:53 ` Florian Ragwitz
2010-05-05 17:12   ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100505171253.GD7337@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=E.A.B.Piel@tudelft.nl \
    --cc=linux-input@vger.kernel.org \
    --cc=rafl@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).