From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 1/2] elantech: Report tool width when it is known Date: Wed, 5 May 2010 10:13:50 -0700 Message-ID: <20100505171350.GE7337@core.coreip.homeip.net> References: <4BE16121.8040000@tudelft.nl> <20100505163951.GB7337@core.coreip.homeip.net> <4BE1A3AA.1090401@tudelft.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-ww0-f46.google.com ([74.125.82.46]:49565 "EHLO mail-ww0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751145Ab0EERN7 (ORCPT ); Wed, 5 May 2010 13:13:59 -0400 Received: by wwb34 with SMTP id 34so21344wwb.19 for ; Wed, 05 May 2010 10:13:57 -0700 (PDT) Content-Disposition: inline In-Reply-To: <4BE1A3AA.1090401@tudelft.nl> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: =?iso-8859-1?Q?=C9ric?= Piel Cc: Florian Ragwitz , "linux-input@vger.kernel.org" On Wed, May 05, 2010 at 06:58:18PM +0200, =C9ric Piel wrote: > Op 05-05-10 18:39, Dmitry Torokhov schreef: > > On Wed, May 05, 2010 at 02:14:25PM +0200, =C9ric Piel wrote: > >> >From observation of the values sent from the hardware version 2, = it > >> seems that the first four bits of byte 1 represents the width. So = we can > >> report it as well. Observed values on my hardware were always betw= een 1 > >> and 12, so let's use this for min and max. > >> > >=20 > > I think we shoudl have threshold for the firmware version when we s= tart > > reporting the width. > >=20 > What do you mean? That the width might not be reported correctly by a= ll > the firmwares? I have no idea if that is the case. For info, IIRC my > firmware report 2.1 with middle byte 8. >=20 My understanding was that older firmwares would report 0. I might be mistaken. --=20 Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html