Re: [PATCH 2/2] elantech: Report multitouch with proper ABS_MT messages

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Wed, May 05, 2010 at 07:06:25PM +0200, Éric Piel wrote:
> Op 05-05-10 18:38, Dmitry Torokhov schreef:
> > Hi Eric,
> > 
> > On Wed, May 05, 2010 at 02:20:46PM +0200, Éric Piel wrote:
> >>
> :
> >>  
> >>  	/* byte 0: n1  n0   .   .   .   .   R   L */
> >>  	fingers = (packet[0] & 0xc0) >> 6;
> >> -	input_report_key(dev, BTN_TOUCH, fingers != 0);
> > 
> > Mousedev works a tad better if BTN_TOUCH is reported first. Otherwise
> > looks good.
> I moved it there because somehow I had understood in the
> multi-touch-protocol that all the old events had to be reported after
> the last SYNC_MT. That said, I don't recall any influence on the
> synaptics nor multitouch X drivers. Maybe it matters just for the ABS_*
> events?

I was talking about mousedev - the in-kernel mouse emulation.

I do not believe the order of events shoudl matter for userspace, which
should collect all data until it receives EV_SYN/SYN_REPORT and then act
upon the collected data.

> 
> > 
> > Henrik, should we report "tool width" as ABS_MT_WIDTH_MAJOR?
> > 
> > Eric, we don't have the "width" for the 2nd point of contact, do we?
> I looked a bit at the values generated when there are two touches, and
> couldn't any changing when I was varying the pressure.
> 
> > Where is the proprietary driver BTW? Do we even care? I'd probably get
> > rid of HAT abuse if our standard tools provide good user experience.
> Actually I had never heard of a proprietary driver before reading the
> code ;-) Maybe Florian knows?
> 
> Eric
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html