linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Chase Douglas <chase.douglas@canonical.com>
Cc: Henrik Rydberg <rydberg@euromail.se>,
	Rafi Rubin <rafi@seas.upenn.edu>,
	Ping Cheng <pinglinux@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Mika Kuoppala <mika.kuoppala@nokia.com>,
	Peter Hutterer <peter.hutterer@who-t.net>,
	Benjamin Tissoires <tissoire@cena.fr>,
	Stephane Chatty <chatty@enac.fr>,
	Michael Poole <mdpoole@troilus.org>
Subject: Re: [PATCH 2/2] input: mt: Document the MT event slot protocol (rev3)
Date: Sat, 22 May 2010 13:56:49 -0700	[thread overview]
Message-ID: <20100522205649.GD30464@core.coreip.homeip.net> (raw)
In-Reply-To: <1274561549.20881.8.camel@mini>

On Sat, May 22, 2010 at 04:52:29PM -0400, Chase Douglas wrote:
> On Sat, 2010-05-22 at 19:47 +0200, Henrik Rydberg wrote:
> > Chase Douglas wrote:
> > > On Sat, 2010-05-22 at 12:38 +0200, Henrik Rydberg wrote:
> > >> Getting serious, it is anyone's guess what will happen next, but I was picturing
> > >> a table, with a large multitouch screen and buttons along the side of the table.
> > >> Sure, we can do "ABS_BTN_0", "ABS_BTN_1", etc, but with slots in place, it seems
> > >> more natural to use something like "ABS_MT_BTN_X". While at it, REL_MT event
> > >> makes sense for those touchscreen techniques which register changes, like
> > >> acoustic pulse recognition.
> > 
> > s/ABS/KEY/
> > 
> > > 
> > > Shouldn't this be handled in userspace? I don't think we want to be
> > > quirking drivers for instances where the same touchscreen is overlaid on
> > > buttons in some cases, but not in others. If we don't quirk, we'd need
> > > some mechanism to tell the driver about such buttons.
> > 
> > Perhaps you would like to clarify what "this" means here, and how you arrive at
> > quirking drivers.
> 
> I'm arriving rather late to the conversation, so this could be a matter
> of me not understanding everything. What I thought you were proposing is
> something like what I have on my Nexus One: an MT area encompassing a
> touchscreen and extending to an area of four "buttons" off the bottom of
> the screen. I was thinking that interactions with these buttons would
> trigger the KEY_MT_BTN events you mentioned. However, if thats the case
> then the driver needs to know of these buttons, so we've gone from a
> dumb touchscreen driver to a driver that must be aware of regions of the
> screen where there are buttons. This is where I think it would be better
> to have a userspace application (X?) understand the properties of the
> screen to know exactly what a touch means, instead of trying to
> interpret it inside the kernel.
> 

Even if kernel driver would be doing the "key" decoding then you would
not need KEY_MT_BTN - input layer will happily handle several keys
pressed at once, so the driver would just emit KEY_WWW, KEY_HOMEPAGE,
KEY_CANCEL, etc, etc. No need to bring in MT protocol here.

-- 
Dmitry

  reply	other threads:[~2010-05-22 20:56 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-21 15:55 [PATCH 1/2] input: mt: Introduce MT event slots (rev 4) Henrik Rydberg
2010-05-21 15:55 ` [PATCH 2/2] input: mt: Document the MT event slot protocol (rev3) Henrik Rydberg
2010-05-21 16:30   ` Ping Cheng
2010-05-21 16:36     ` Henrik Rydberg
2010-05-21 16:52       ` Dmitry Torokhov
2010-05-21 16:56         ` Henrik Rydberg
2010-05-21 17:22           ` Dmitry Torokhov
2010-05-21 17:29             ` Henrik Rydberg
2010-05-21 17:41               ` Dmitry Torokhov
2010-05-21 17:49                 ` Henrik Rydberg
2010-05-22  3:52                   ` Ping Cheng
2010-05-22  7:08                     ` Henrik Rydberg
2010-05-22  9:11                     ` Henrik Rydberg
2010-05-22  9:33                   ` Rafi Rubin
2010-05-22 10:38                     ` Henrik Rydberg
2010-05-22 14:46                       ` Chase Douglas
2010-05-22 17:47                         ` Henrik Rydberg
2010-05-22 20:52                           ` Chase Douglas
2010-05-22 20:56                             ` Dmitry Torokhov [this message]
2010-05-22 21:09                             ` Henrik Rydberg
2010-05-22 20:16                       ` Dmitry Torokhov
2010-05-22 21:15                         ` Henrik Rydberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100522205649.GD30464@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=chase.douglas@canonical.com \
    --cc=chatty@enac.fr \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mdpoole@troilus.org \
    --cc=mika.kuoppala@nokia.com \
    --cc=peter.hutterer@who-t.net \
    --cc=pinglinux@gmail.com \
    --cc=rafi@seas.upenn.edu \
    --cc=rydberg@euromail.se \
    --cc=tissoire@cena.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).