* [PATCH -next] hid: roccat modules interdependencies
[not found] <20100527152628.b23a14c6.sfr@canb.auug.org.au>
@ 2010-05-27 16:07 ` Randy Dunlap
2010-05-31 11:58 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2010-05-27 16:07 UTC (permalink / raw)
To: Stephen Rothwell, Jiri Kosina, Stefan Achatz
Cc: linux-next, LKML, linux-input
From: Randy Dunlap <randy.dunlap@oracle.com>
hid-roccat-kone calls the hid-roccat module interfaces,
so the former should depend on or select the latter to prevent
build errors, like:
hid-roccat-kone.c:(.text+0x133ed2): undefined reference to `roccat_report_event'
hid-roccat-kone.c:(.text+0x133fa8): undefined reference to `roccat_disconnect'
hid-roccat-kone.c:(.text+0x1353be): undefined reference to `roccat_connect'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/hid/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20100527.orig/drivers/hid/Kconfig
+++ linux-next-20100527/drivers/hid/Kconfig
@@ -358,6 +358,7 @@ config HID_ROCCAT
config HID_ROCCAT_KONE
tristate "Roccat Kone Mouse support"
depends on USB_HID
+ select HID_ROCCAT
---help---
Support for Roccat Kone mouse.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] hid: roccat modules interdependencies
2010-05-27 16:07 ` [PATCH -next] hid: roccat modules interdependencies Randy Dunlap
@ 2010-05-31 11:58 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2010-05-31 11:58 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, Stefan Achatz, linux-next, LKML, linux-input
On Thu, 27 May 2010, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> hid-roccat-kone calls the hid-roccat module interfaces,
> so the former should depend on or select the latter to prevent
> build errors, like:
>
> hid-roccat-kone.c:(.text+0x133ed2): undefined reference to `roccat_report_event'
> hid-roccat-kone.c:(.text+0x133fa8): undefined reference to `roccat_disconnect'
> hid-roccat-kone.c:(.text+0x1353be): undefined reference to `roccat_connect'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> drivers/hid/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20100527.orig/drivers/hid/Kconfig
> +++ linux-next-20100527/drivers/hid/Kconfig
> @@ -358,6 +358,7 @@ config HID_ROCCAT
> config HID_ROCCAT_KONE
> tristate "Roccat Kone Mouse support"
> depends on USB_HID
> + select HID_ROCCAT
> ---help---
> Support for Roccat Kone mouse.
Applied, thanks Randy.
--
Jiri Kosina
SUSE Labs, Novell Inc.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-31 11:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20100527152628.b23a14c6.sfr@canb.auug.org.au>
2010-05-27 16:07 ` [PATCH -next] hid: roccat modules interdependencies Randy Dunlap
2010-05-31 11:58 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).