[PATCH] hid: ignore digitizer usage Undefined (0x00)

[PATCH] hid: ignore digitizer usage Undefined (0x00)

[Forest Bond]

[-- Attachment #1: Type: text/plain, Size: 1024 bytes --]

SMART Technologies has recommended this change to fix a problem reported
with SMART Board series interactive whiteboards.

A description of the device-specific symptom follows:

  When the board is connected my mouse bounces up to the top left corner.

Bjorn has tested this fix with model SB680.

Tested-by: Bjorn Behrendt <bbehrendt@msjvermont.org>
Signed-off-by: Forest Bond <forest@alittletooquiet.net>
---
 drivers/hid/hid-input.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
index 7a0d2e4..6b10e5a 100644
--- a/drivers/hid/hid-input.c
+++ b/drivers/hid/hid-input.c
@@ -301,6 +301,9 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
 
 	case HID_UP_DIGITIZER:
 		switch (usage->hid & 0xff) {
+		case 0x00: /* Undefined */
+			goto ignore;
+
 		case 0x30: /* TipPressure */
 			if (!test_bit(BTN_TOUCH, input->keybit)) {
 				device->quirks |= HID_QUIRK_NOTOUCH;
-- 
1.7.0.4

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH] hid: ignore digitizer usage Undefined (0x00)

[Forest Bond]

[-- Attachment #1: Type: text/plain, Size: 1330 bytes --]

Hi,

I'm not sure if anyone noticed this patch.  Did I send it to the right place?

Thanks,
Forest
-- 
Forest Bond
http://www.alittletooquiet.net
http://www.pytagsfs.org

On Thu, May 27, 2010 at 11:18:08AM -0400, Forest Bond wrote:
> SMART Technologies has recommended this change to fix a problem reported
> with SMART Board series interactive whiteboards.
> 
> A description of the device-specific symptom follows:
> 
>   When the board is connected my mouse bounces up to the top left corner.
> 
> Bjorn has tested this fix with model SB680.
> 
> Tested-by: Bjorn Behrendt <bbehrendt@msjvermont.org>
> Signed-off-by: Forest Bond <forest@alittletooquiet.net>
> ---
>  drivers/hid/hid-input.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> index 7a0d2e4..6b10e5a 100644
> --- a/drivers/hid/hid-input.c
> +++ b/drivers/hid/hid-input.c
> @@ -301,6 +301,9 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
>  
>  	case HID_UP_DIGITIZER:
>  		switch (usage->hid & 0xff) {
> +		case 0x00: /* Undefined */
> +			goto ignore;
> +
>  		case 0x30: /* TipPressure */
>  			if (!test_bit(BTN_TOUCH, input->keybit)) {
>  				device->quirks |= HID_QUIRK_NOTOUCH;
> -- 
> 1.7.0.4

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH] hid: ignore digitizer usage Undefined (0x00)

[Forest Bond]

[-- Attachment #1: Type: text/plain, Size: 1371 bytes --]

Hi Jiri,

This patch has gone ignored on the linux-input mailing list.  Perhaps that was
done intentionally, but I wanted to try once more to get it looked at before
giving up.

Can you comment?

Thanks,
Forest

On Thu, May 27, 2010 at 11:18:08AM -0400, Forest Bond wrote:
> SMART Technologies has recommended this change to fix a problem reported
> with SMART Board series interactive whiteboards.
> 
> A description of the device-specific symptom follows:
> 
>   When the board is connected my mouse bounces up to the top left corner.
> 
> Bjorn has tested this fix with model SB680.
> 
> Tested-by: Bjorn Behrendt <bbehrendt@msjvermont.org>
> Signed-off-by: Forest Bond <forest@alittletooquiet.net>
> ---
>  drivers/hid/hid-input.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> index 7a0d2e4..6b10e5a 100644
> --- a/drivers/hid/hid-input.c
> +++ b/drivers/hid/hid-input.c
> @@ -301,6 +301,9 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
>  
>  	case HID_UP_DIGITIZER:
>  		switch (usage->hid & 0xff) {
> +		case 0x00: /* Undefined */
> +			goto ignore;
> +
>  		case 0x30: /* TipPressure */
>  			if (!test_bit(BTN_TOUCH, input->keybit)) {
>  				device->quirks |= HID_QUIRK_NOTOUCH;
> -- 
> 1.7.0.4

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH] hid: ignore digitizer usage Undefined (0x00)

[Jiri Kosina]

On Thu, 27 May 2010, Forest Bond wrote:

> SMART Technologies has recommended this change to fix a problem reported
> with SMART Board series interactive whiteboards.
> 
> A description of the device-specific symptom follows:
> 
>   When the board is connected my mouse bounces up to the top left corner.
> 
> Bjorn has tested this fix with model SB680.
> 
> Tested-by: Bjorn Behrendt <bbehrendt@msjvermont.org>
> Signed-off-by: Forest Bond <forest@alittletooquiet.net>
> ---
>  drivers/hid/hid-input.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> index 7a0d2e4..6b10e5a 100644
> --- a/drivers/hid/hid-input.c
> +++ b/drivers/hid/hid-input.c
> @@ -301,6 +301,9 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
>  
>  	case HID_UP_DIGITIZER:
>  		switch (usage->hid & 0xff) {
> +		case 0x00: /* Undefined */
> +			goto ignore;
> +
>  		case 0x30: /* TipPressure */
>  			if (!test_bit(BTN_TOUCH, input->keybit)) {
>  				device->quirks |= HID_QUIRK_NOTOUCH;

Hi,

I have applied the patch as it makes sense per se.

Still, I'd be interested to know what is the device in question actually 
sending and what it has in its report descriptor. Does it indeed use 0x00 
code? For what reason?

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.

Re: [PATCH] hid: ignore digitizer usage Undefined (0x00)

[Forest Bond]

[-- Attachment #1: Type: text/plain, Size: 1819 bytes --]

Hi Jiri,

On Tue, Jul 13, 2010 at 11:52:27PM +0200, Jiri Kosina wrote:
> On Thu, 27 May 2010, Forest Bond wrote:
> > SMART Technologies has recommended this change to fix a problem reported
> > with SMART Board series interactive whiteboards.
> > 
> > A description of the device-specific symptom follows:
> > 
> >   When the board is connected my mouse bounces up to the top left corner.
> > 
> > Bjorn has tested this fix with model SB680.
> > 
> > Tested-by: Bjorn Behrendt <bbehrendt@msjvermont.org>
> > Signed-off-by: Forest Bond <forest@alittletooquiet.net>
> > ---
> >  drivers/hid/hid-input.c |    3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> > index 7a0d2e4..6b10e5a 100644
> > --- a/drivers/hid/hid-input.c
> > +++ b/drivers/hid/hid-input.c
> > @@ -301,6 +301,9 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
> >  
> >  	case HID_UP_DIGITIZER:
> >  		switch (usage->hid & 0xff) {
> > +		case 0x00: /* Undefined */
> > +			goto ignore;
> > +
> >  		case 0x30: /* TipPressure */
> >  			if (!test_bit(BTN_TOUCH, input->keybit)) {
> >  				device->quirks |= HID_QUIRK_NOTOUCH;
> 
> Hi,
> 
> I have applied the patch as it makes sense per se.

Thanks!  I hope your holiday was pleasant.

> Still, I'd be interested to know what is the device in question actually 
> sending and what it has in its report descriptor. Does it indeed use 0x00 
> code? For what reason?

I wish I could answer that for you.  I don't really know much about the device
(I haven't actually seen one myself).

I'll try to request more information from the manufacturer.

Thanks,
Forest
-- 
Forest Bond
http://www.alittletooquiet.net
http://www.pytagsfs.org

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]