Re: [NEEDS TEST][PATCH] elantech: discard the first 2 positions reports for some firmwares

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Sun, May 30, 2010 at 02:55:32PM -0400, Chase Douglas wrote:
> On Sun, 2010-05-30 at 11:26 -0700, Dmitry Torokhov wrote:
> > On Sun, May 30, 2010 at 02:11:54PM -0400, Chase Douglas wrote:
> > > On Sun, 2010-05-30 at 20:42 +0200, Éric Piel wrote:
> > > > According to the Dell/Ubuntu driver, what was previously observed as "jumpy cursor"
> > > > corresponds to the hardware sending incorrect data for the first two reports of a 
> > > > one touch finger. So let's use the same workaround as in the other driver. Also,
> > > > detect another firmware version with the same behaviour, as in the other driver.
> > > 
> > > I can't find this code in any of the Ubuntu released kernels. Where did
> > > you find this patch?
> > 
> > http://zinc.ubuntu.com/git?p=mid-team/hardy-netbook.git;a=commitdiff;h=dfc02dc860ccef79e7bce095c872548f914d96bf
> > 
> > Woudl be nice if we did not have to hunt through random repos to find
> > it...
> 
> I completely agree. We are trying to consolidate our repos as much as
> possible. The Hardy release was two years ago, and we admittedly had too
> many repos with sources for different hardy kernels. We now have just
> one repo for each of our recent kernel releases, and probably will have
> only one master branch even for Maverick.
> 
> As for this patch, I still don't see it in the commit you linked to.
> There's nothing in that version of the driver that discards packets,
> checks firmware versions, or enables jumpy cursor logic.

The patch was not taken from the commit, Eric just referenced the commit
as he gathered some additional information. The code in that commit is
so hideous that it would never get close to mainline as is.

> 
> If we did apply this patch somewhere and overlooked upstreaming it, then
> that was a mistake on our part. We would also be just as concerned as
> you are, since we don't seem to carry this patch in any Ubuntu supported
> kernels that I am aware of.
> 
> Thanks,
> 
> -- Chase
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html