From: Jindrich Makovicka <makovick@gmail.com>
To: linux-input@vger.kernel.org
Subject: Re: [PATCH] HID: check for HID_QUIRK_IGNORE during probing
Date: Mon, 31 May 2010 10:01:14 +0200 [thread overview]
Message-ID: <20100531100114.0c808b91@holly> (raw)
In-Reply-To: <20100526082423.627f8cac@holly>
On Wed, 26 May 2010 08:24:23 +0200
Jindrich Makovicka <makovick@gmail.com> wrote:
> On Tue, 25 May 2010 23:41:02 +0100
> Bastien Nocera <hadess@hadess.net> wrote:
>
> > On Tue, 2010-05-25 at 22:53 +0200, Jindrich Makovicka wrote:
> > > Updated to current git:
> > >
> > > --- hid-core.c.orig 2010-05-25 22:04:58.000000000 +0200
> > > +++ hid-core.c 2010-05-25 22:08:53.791241376 +0200
> > > @@ -1759,7 +1759,8 @@
> > >
> > > /* we need to kill them here, otherwise they will stay
> > > allocated to
> > > * wait for coming driver */
> > > - if (!(hdev->quirks & HID_QUIRK_NO_IGNORE) &&
> > > hid_ignore(hdev))
> > > + if (!(hdev->quirks & HID_QUIRK_NO_IGNORE)
> > > + && (hid_ignore(hdev) || (hdev->quirks &
> > > HID_QUIRK_IGNORE))) return -ENODEV;
> > >
> > > /* XXX hack, any other cleaner solution after the driver
> > > core
> >
> > Wouldn't that mean that a device with HID_QUIRK_IGNORE for which we
> > pass HID_QUIRK_NO_IGNORE, would still be ignored?
>
> With HID_QUIRK_NO_IGNORE, the whole expression will be FALSE, and the
> part after && wouldn't be even evaluated in both current and patched
> version. So, NO_IGNORE takes precedence over IGNORE.
>
Ping?
--
Jindrich Makovicka
prev parent reply other threads:[~2010-05-31 8:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-23 18:47 [PATCH] HID: check for HID_QUIRK_IGNORE during probing Jindrich Makovicka
2010-05-25 20:53 ` Jindrich Makovicka
2010-05-25 22:41 ` Bastien Nocera
2010-05-26 6:24 ` Jindrich Makovicka
2010-05-31 8:01 ` Jindrich Makovicka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100531100114.0c808b91@holly \
--to=makovick@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).