From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] drivers: remove all i2c_set_clientdata(client, NULL) Date: Mon, 31 May 2010 14:01:58 +0100 Message-ID: <20100531130157.GA10507@rakim.wolfsonmicro.main> References: <1275310552-14685-1-git-send-email-w.sang@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from opensource.wolfsonmicro.com ([80.75.67.52]:52961 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754032Ab0EaNCB (ORCPT ); Mon, 31 May 2010 09:02:01 -0400 Content-Disposition: inline In-Reply-To: <1275310552-14685-1-git-send-email-w.sang@pengutronix.de> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Wolfram Sang Cc: linux-i2c@vger.kernel.org, Jean Delvare , George Joseph , Riku Voipio , Guillaume Ligneul , "Ben Dooks (embedded platforms)" , Dmitry Torokhov , Alessandro Rubini , Richard Purdie , Colin Leroy , Benjamin Herrenschmidt , Mauro Carvalho Chehab , Samuel Ortiz , David Woodhouse , Liam Girdwood , Paul Gortmaker , Alessandro Zummo , Greg Kroah-Hartman , lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linuxppc-dev@ozlabs.org, linux-media@vger.kernel.orglinu On Mon, May 31, 2010 at 02:55:48PM +0200, Wolfram Sang wrote: > I2C-drivers can use the clientdata-pointer to point to private data. As I2C > devices are not really unregistered, but merely detached from their driver, it > used to be the drivers obligation to clear this pointer during remove() or a > failed probe(). As a couple of drivers forgot to do this, it was agreed that it > was cleaner if the i2c-core does this clearance when appropriate, as there is > no guarantee for the lifetime of the clientdata-pointer after remove() anyhow. > This feature was added to the core with commit > e4a7b9b04de15f6b63da5ccdd373ffa3057a3681 to fix the faulty drivers. > > As there is no need anymore to clear the clientdata-pointer, remove all current > occurrences in the drivers to simplify the code and prevent confusion. > > Signed-off-by: Wolfram Sang Acked-by: Mark Brown