* [PATCH] input: Tone down logging from S3C touchscreen driver
@ 2010-05-31 17:52 Mark Brown
2010-05-31 19:03 ` Dmitry Torokhov
2010-05-31 23:19 ` Ben Dooks
0 siblings, 2 replies; 3+ messages in thread
From: Mark Brown @ 2010-05-31 17:52 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Ben Dooks, linux-input, linux-kernel, Mark Brown
The S3C touchscreen driver is logging at LOG_INFO on every stylus up
event which spams the console needlessly. Reduce the priority of the
message to debug level for some peace and quiet.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/input/touchscreen/s3c2410_ts.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/input/touchscreen/s3c2410_ts.c b/drivers/input/touchscreen/s3c2410_ts.c
index ac5d0f9..6085d12 100644
--- a/drivers/input/touchscreen/s3c2410_ts.c
+++ b/drivers/input/touchscreen/s3c2410_ts.c
@@ -173,7 +173,7 @@ static irqreturn_t stylus_irq(int irq, void *dev_id)
if (down)
s3c_adc_start(ts.client, 0, 1 << ts.shift);
else
- dev_info(ts.dev, "%s: count=%d\n", __func__, ts.count);
+ dev_dbg(ts.dev, "%s: count=%d\n", __func__, ts.count);
if (ts.features & FEAT_PEN_IRQ) {
/* Clear pen down/up interrupt */
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] input: Tone down logging from S3C touchscreen driver
2010-05-31 17:52 [PATCH] input: Tone down logging from S3C touchscreen driver Mark Brown
@ 2010-05-31 19:03 ` Dmitry Torokhov
2010-05-31 23:19 ` Ben Dooks
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2010-05-31 19:03 UTC (permalink / raw)
To: Mark Brown; +Cc: Ben Dooks, linux-input, linux-kernel
On Mon, May 31, 2010 at 06:52:51PM +0100, Mark Brown wrote:
> The S3C touchscreen driver is logging at LOG_INFO on every stylus up
> event which spams the console needlessly. Reduce the priority of the
> message to debug level for some peace and quiet.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Applied, thank you Mark.
> ---
> drivers/input/touchscreen/s3c2410_ts.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/input/touchscreen/s3c2410_ts.c b/drivers/input/touchscreen/s3c2410_ts.c
> index ac5d0f9..6085d12 100644
> --- a/drivers/input/touchscreen/s3c2410_ts.c
> +++ b/drivers/input/touchscreen/s3c2410_ts.c
> @@ -173,7 +173,7 @@ static irqreturn_t stylus_irq(int irq, void *dev_id)
> if (down)
> s3c_adc_start(ts.client, 0, 1 << ts.shift);
> else
> - dev_info(ts.dev, "%s: count=%d\n", __func__, ts.count);
> + dev_dbg(ts.dev, "%s: count=%d\n", __func__, ts.count);
>
> if (ts.features & FEAT_PEN_IRQ) {
> /* Clear pen down/up interrupt */
> --
> 1.7.1
>
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] input: Tone down logging from S3C touchscreen driver
2010-05-31 17:52 [PATCH] input: Tone down logging from S3C touchscreen driver Mark Brown
2010-05-31 19:03 ` Dmitry Torokhov
@ 2010-05-31 23:19 ` Ben Dooks
1 sibling, 0 replies; 3+ messages in thread
From: Ben Dooks @ 2010-05-31 23:19 UTC (permalink / raw)
To: Mark Brown; +Cc: Dmitry Torokhov, Ben Dooks, linux-input, linux-kernel
On Mon, May 31, 2010 at 06:52:51PM +0100, Mark Brown wrote:
> The S3C touchscreen driver is logging at LOG_INFO on every stylus up
> event which spams the console needlessly. Reduce the priority of the
> message to debug level for some peace and quiet.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Acekd-by: Ben Dooks <ben-linux@fluff.org>
> ---
> drivers/input/touchscreen/s3c2410_ts.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/input/touchscreen/s3c2410_ts.c b/drivers/input/touchscreen/s3c2410_ts.c
> index ac5d0f9..6085d12 100644
> --- a/drivers/input/touchscreen/s3c2410_ts.c
> +++ b/drivers/input/touchscreen/s3c2410_ts.c
> @@ -173,7 +173,7 @@ static irqreturn_t stylus_irq(int irq, void *dev_id)
> if (down)
> s3c_adc_start(ts.client, 0, 1 << ts.shift);
> else
> - dev_info(ts.dev, "%s: count=%d\n", __func__, ts.count);
> + dev_dbg(ts.dev, "%s: count=%d\n", __func__, ts.count);
>
> if (ts.features & FEAT_PEN_IRQ) {
> /* Clear pen down/up interrupt */
> --
> 1.7.1
>
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-05-31 23:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-31 17:52 [PATCH] input: Tone down logging from S3C touchscreen driver Mark Brown
2010-05-31 19:03 ` Dmitry Torokhov
2010-05-31 23:19 ` Ben Dooks
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).