From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Dan Carpenter <error27@gmail.com>
Cc: Todd Fischer <todd.fischer@ridgerun.com>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch 1/2] input/tps6507x-ts: dereferencing before checking
Date: Mon, 31 May 2010 12:17:23 -0700 [thread overview]
Message-ID: <20100531191723.GE30712@core.coreip.homeip.net> (raw)
In-Reply-To: <20100531120122.GR5483@bicker>
On Mon, May 31, 2010 at 02:01:22PM +0200, Dan Carpenter wrote:
> This patch moves the dereference after the check for NULL.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/input/touchscreen/tps6507x-ts.c b/drivers/input/touchscreen/tps6507x-ts.c
> index 5de80a1..b99db09 100644
> --- a/drivers/input/touchscreen/tps6507x-ts.c
> +++ b/drivers/input/touchscreen/tps6507x-ts.c
> @@ -355,10 +355,11 @@ static int __devexit tps6507x_ts_remove(struct platform_device *pdev)
> {
> struct tps6507x_dev *tps6507x_dev = platform_get_drvdata(pdev);
> struct tps6507x_ts *tsc = tps6507x_dev->ts;
> - struct input_dev *input_dev = tsc->input_dev;
> + struct input_dev *input_dev;
>
> if (!tsc)
> return 0;
> + input_dev = tsc->input_dev;
>
Why would tsc ever be NULL?
Also I really do not like that pdev's driver data that is supposed to be
driver-private data is being used by the parent. Parent should be using
it's own drvdata and leave child's data alone. We should probably do in
platform code what I2C is about to do and clear drvdata on unbind
automatically to prevent this kind of misuse.
--
Dmitry
next prev parent reply other threads:[~2010-05-31 19:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-31 12:01 [patch 1/2] input/tps6507x-ts: dereferencing before checking Dan Carpenter
2010-05-31 19:17 ` Dmitry Torokhov [this message]
2010-05-31 20:40 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100531191723.GE30712@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=todd.fischer@ridgerun.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).