From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [PATCH] drivers: remove all i2c_set_clientdata(client, NULL) Date: Tue, 1 Jun 2010 15:53:10 +0200 Message-ID: <20100601155310.3781fce6@hyperion.delvare> References: <1275310552-14685-1-git-send-email-w.sang@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1275310552-14685-1-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wolfram Sang Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, George Joseph , Riku Voipio , Guillaume Ligneul , "Ben Dooks (embedded platforms)" , Dmitry Torokhov , Alessandro Rubini , Richard Purdie , Colin Leroy , Benjamin Herrenschmidt , Mauro Carvalho Chehab , Samuel Ortiz , Mark Brown , David Woodhouse , Liam Girdwood , Paul Gortmaker , Alessandro Zummo , Greg Kroah-Hartman , lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org, linux-media@vger.k List-Id: linux-input@vger.kernel.org On Mon, 31 May 2010 14:55:48 +0200, Wolfram Sang wrote: > I2C-drivers can use the clientdata-pointer to point to private data. As I2C > devices are not really unregistered, but merely detached from their driver, it > used to be the drivers obligation to clear this pointer during remove() or a > failed probe(). As a couple of drivers forgot to do this, it was agreed that it > was cleaner if the i2c-core does this clearance when appropriate, as there is > no guarantee for the lifetime of the clientdata-pointer after remove() anyhow. > This feature was added to the core with commit > e4a7b9b04de15f6b63da5ccdd373ffa3057a3681 to fix the faulty drivers. > > As there is no need anymore to clear the clientdata-pointer, remove all current > occurrences in the drivers to simplify the code and prevent confusion. > > Signed-off-by: Wolfram Sang > Cc: Jean Delvare > (...) Applied, thanks. Will go to Linus in the next few days. -- Jean Delvare