From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Dan Carpenter <error27@gmail.com>
Cc: Todd Fischer <todd.fischer@ridgerun.com>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] input/tps6507x-ts: a couple work queue cleanups
Date: Tue, 1 Jun 2010 23:57:11 -0700 [thread overview]
Message-ID: <20100602065711.GB3713@core.coreip.homeip.net> (raw)
In-Reply-To: <20100601152744.GN5483@bicker>
Hi Dan,
On Tue, Jun 01, 2010 at 05:27:45PM +0200, Dan Carpenter wrote:
> 1) Use msecs_to_jiffies() instead of calculating by hand.
> 2) Call cancel_delayed_work_sync() instead of cancel_delayed_work()
> followed by a separate flush_workqueue().
> 3) Remove the "tsc->wq = 0;" Sparse complains about that because
> tsc->wq is a pointer, not an int. It's not needed because we just
> free the pointer anyway.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
Applied the patch, thank you, but more cleanups needed.
> diff --git a/drivers/input/touchscreen/tps6507x-ts.c b/drivers/input/touchscreen/tps6507x-ts.c
> index 5de80a1..5b70a14 100644
> --- a/drivers/input/touchscreen/tps6507x-ts.c
> +++ b/drivers/input/touchscreen/tps6507x-ts.c
> @@ -221,7 +221,7 @@ done:
>
> if (poll) {
> schd = queue_delayed_work(tsc->wq, &tsc->work,
> - tsc->poll_period * HZ / 1000);
> + msecs_to_jiffies(tsc->poll_period));
> if (schd)
I think the driver author misunderstood the return values of
queue_delayed_work().
> tsc->polling = 1;
> else {
> @@ -326,7 +326,7 @@ static int tps6507x_ts_probe(struct platform_device *pdev)
> goto err2;
>
> schd = queue_delayed_work(tsc->wq, &tsc->work,
> - tsc->poll_period * HZ / 1000);
> + msecs_to_jiffies(tsc->poll_period));
>
> if (schd)
> tsc->polling = 1;
> @@ -339,10 +339,8 @@ static int tps6507x_ts_probe(struct platform_device *pdev)
> return 0;
>
> err2:
> - cancel_delayed_work(&tsc->work);
> - flush_workqueue(tsc->wq);
> + cancel_delayed_work_sync(&tsc->work);
> destroy_workqueue(tsc->wq);
> - tsc->wq = 0;
> input_free_device(input_dev);
> err1:
> kfree(tsc);
> @@ -360,10 +358,8 @@ static int __devexit tps6507x_ts_remove(struct platform_device *pdev)
> if (!tsc)
> return 0;
>
> - cancel_delayed_work(&tsc->work);
> - flush_workqueue(tsc->wq);
> + cancel_delayed_work_sync(&tsc->work);
> destroy_workqueue(tsc->wq);
> - tsc->wq = 0;
>
> input_free_device(input_dev);
This should be input_unregister_device().
I also question the production utility of a driver that continuously
poll device every 30 ms... I think that it was merged prematurely,
without adequate review ;(
--
Dmitry
prev parent reply other threads:[~2010-06-02 6:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-01 15:27 [patch] input/tps6507x-ts: a couple work queue cleanups Dan Carpenter
2010-06-02 6:57 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100602065711.GB3713@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=todd.fischer@ridgerun.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).