From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Thomas Weber <weber@corscience.de>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: ads7846: Fix warning about output format
Date: Wed, 2 Jun 2010 00:39:56 -0700 [thread overview]
Message-ID: <20100602073955.GH3713@core.coreip.homeip.net> (raw)
In-Reply-To: <1275461429-4838-1-git-send-email-weber@corscience.de>
On Wed, Jun 02, 2010 at 08:50:29AM +0200, Thomas Weber wrote:
> This patch fixes a compiler warning about wrong output format.
>
> drivers/input/touchscreen/ads7846.c: In function 'ads7846_probe':
> drivers/input/touchscreen/ads7846.c:1167: warning: format '%ld' expects
> type 'long int', but argument 4 has type 'int'
>
> Introduced by commit 067fb2f648543894ce775082c5636f4c32b99e4f ("Input:
> ads7846 - return error on regulator_get() failure").
>
> The ERR_PTR returns a long so the variable err needs to be long.
No, int works just as well. I have a patch that simply fixes format
specification.
Thanks.
--
Dmitry
prev parent reply other threads:[~2010-06-02 7:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-02 6:50 [PATCH] Input: ads7846: Fix warning about output format Thomas Weber
2010-06-02 7:39 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100602073955.GH3713@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=weber@corscience.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).