linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Henrik Rydberg <rydberg@euromail.se>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jiri Kosina <jkosina@suse.cz>,
	Mika Kuoppala <mika.kuoppala@nokia.com>,
	Benjamin Tissoires <tissoire@cena.fr>,
	Rafi Rubin <rafi@seas.upenn.edu>
Subject: Re: [PATCH 3/4] input: evdev: Convert to dynamic event buffer (rev3)
Date: Thu, 3 Jun 2010 23:37:34 -0700	[thread overview]
Message-ID: <20100604063734.GD21239@core.coreip.homeip.net> (raw)
In-Reply-To: <1275552062-8153-4-git-send-email-rydberg@euromail.se>

On Thu, Jun 03, 2010 at 10:01:01AM +0200, Henrik Rydberg wrote:
>  
> +	evdev->bufsize = evdev_compute_buffer_size(dev);
> +	evdev->buffer = kzalloc(evdev->bufsize * sizeof(struct input_event),
> +				GFP_KERNEL);

kcalloc().

> +	if (!evdev->buffer) {
> +		error = -ENOMEM;
> +		goto err_free_evdev;
> +	}
> +
>  	error = input_register_handle(&evdev->handle);
>  	if (error)
>  		goto err_free_evdev;

-- 
Dmitry

  parent reply	other threads:[~2010-06-04  6:37 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-03  8:00 [PATCH 0/4] input: evdev: Dynamic buffers (rev3) Henrik Rydberg
2010-06-03  8:00 ` [PATCH 1/4] input: Introduce buflock, a one-to-many circular buffer mechanism Henrik Rydberg
2010-06-03  8:01   ` [PATCH 2/4] input: evdev: Use multi-reader buffer to save space (rev3) Henrik Rydberg
2010-06-03  8:01     ` [PATCH 3/4] input: evdev: Convert to dynamic event buffer (rev3) Henrik Rydberg
2010-06-03  8:01       ` [PATCH 4/4] input: Use driver hint to compute the evdev buffer size Henrik Rydberg
2010-06-04  6:34         ` Dmitry Torokhov
2010-06-04  6:37       ` Dmitry Torokhov [this message]
2010-06-04  6:56   ` [PATCH 1/4] input: Introduce buflock, a one-to-many circular buffer mechanism Dmitry Torokhov
2010-06-04  8:43     ` Henrik Rydberg
2010-06-04 16:36       ` Dmitry Torokhov
2010-06-04 17:08       ` Jonathan Cameron
2010-06-04 19:13       ` Oleg Nesterov
2010-06-04 19:43         ` Henrik Rydberg
2010-06-05 17:40           ` Oleg Nesterov
2010-06-05 18:34             ` Henrik Rydberg
2010-06-04 16:36     ` Henrik Rydberg
2010-06-05  1:35   ` Andrew Morton
2010-06-05 11:21     ` Henrik Rydberg
2010-06-04  6:59 ` [PATCH 0/4] input: evdev: Dynamic buffers (rev3) Dmitry Torokhov
2010-06-04 16:11   ` Henrik Rydberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100604063734.GD21239@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.kuoppala@nokia.com \
    --cc=rafi@seas.upenn.edu \
    --cc=rydberg@euromail.se \
    --cc=tissoire@cena.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).