Re: [PATCH 3/4] ir-core: move decoding state to ir_raw_event_ctrl

["David Härdeman" <david@hardeman.nu>]

On Wed, Jun 09, 2010 at 09:29:08AM -0400, Jarod Wilson wrote:
> On Tue, Jun 08, 2010 at 11:46:36PM -0400, Jarod Wilson wrote:
> > On Tue, Jun 8, 2010 at 1:50 PM, David Härdeman <david@hardeman.nu> wrote:
> > > b) Mauro mentioned in <4BDF28C0.4060102@redhat.com> that:
> > >
> > >        I liked the idea of your redesign, but I didn't like the removal
> > >        of a per-decoder sysfs entry. As already discussed, there are
> > >        cases where we'll need a per-decoder sysfs entry (lirc_dev is
> > >        probably one of those cases - also Jarod's imon driver is
> > >        currently implementing a modprobe parameter that needs to be
> > >        moved to the driver).
> > >
> > >   could you please confirm if your lirc and/or imon drivers would be
> > >   negatively affected by the proposed patches?
> > 
> > Will do so once I get them wedged in on top.
> 
> Got it all merged and compiling, but not yet runtime tested. Compiling
> alone sheds some light on things though...
> 
> So this definitely negatively impacts my ir-core-to-lirc_dev
> (ir-lirc-codec.c) bridge driver, as it was doing the lirc_dev device
> registration work in its register function. However, if (after your
> patchset) we add a new pair of callbacks replacing raw_register and
> raw_unregister, which are optional, that work could be done there instead,
> so I don't think this is an insurmountable obstacle for the lirc bits.

While I'm not sure exactly what callbacks you're suggesting, it still 
sounds like the callbacks would have the exact same problems that the 
current code has (i.e. the decoder will be blissfully unaware of 
hardware which exists before the decoder is loaded). Right?

> As for the imon driver, the modprobe parameter in question (iirc) was
> already removed from the driver, as its functionality is replaced by
> implementing a change_protocol callback. However, there's a request to
> add it (or something like it) back to the driver to allow disabling the
> IR part altogether, and there are a few other modparams that might be
> better suited as sysfs entries. However, its actually not relevant to the
> case of registering raw protocol handlers, as the imon devices do their
> decoding in hardware. I can see the possibility for protocol-specific
> knobs in sysfs though. But I think the same optional callbacks I'd use to
> keep the lirc bits working could also be used for this. Can't think of a
> good name for these yet, probably need more coffee first... ;)

But those sysfs entries wouldn't be 
per-decoder-per-hardware-device....they'd just be 
per-hardware-device...right?

-- 
David Härdeman
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html