From mboxrd@z Thu Jan 1 00:00:00 1970 From: David =?iso-8859-1?Q?H=E4rdeman?= Subject: Re: [PATCH 3/4] ir-core: move decoding state to ir_raw_event_ctrl Date: Wed, 9 Jun 2010 19:56:21 +0200 Message-ID: <20100609175621.GA19620@hardeman.nu> References: <20100424210843.11570.82007.stgit@localhost.localdomain> <20100424211411.11570.2189.stgit@localhost.localdomain> <4BDF2B45.9060806@redhat.com> <20100607190003.GC19390@hardeman.nu> <20100607201530.GG16638@redhat.com> <20100608175017.GC5181@hardeman.nu> <20100609132908.GM16638@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from 1-1-12-13a.han.sth.bostream.se ([82.182.30.168]:60911 "EHLO palpatine.hardeman.nu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754200Ab0FIR4Z (ORCPT ); Wed, 9 Jun 2010 13:56:25 -0400 Content-Disposition: inline In-Reply-To: <20100609132908.GM16638@redhat.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Jarod Wilson Cc: Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-input@vger.kernel.org On Wed, Jun 09, 2010 at 09:29:08AM -0400, Jarod Wilson wrote: > On Tue, Jun 08, 2010 at 11:46:36PM -0400, Jarod Wilson wrote: > > On Tue, Jun 8, 2010 at 1:50 PM, David H=E4rdeman wrote: > > > b) Mauro mentioned in <4BDF28C0.4060102@redhat.com> that: > > > > > > =A0 =A0 =A0 =A0I liked the idea of your redesign, but I didn't li= ke the removal > > > =A0 =A0 =A0 =A0of a per-decoder sysfs entry. As already discussed= , there are > > > =A0 =A0 =A0 =A0cases where we'll need a per-decoder sysfs entry (= lirc_dev is > > > =A0 =A0 =A0 =A0probably one of those cases - also Jarod's imon dr= iver is > > > =A0 =A0 =A0 =A0currently implementing a modprobe parameter that n= eeds to be > > > =A0 =A0 =A0 =A0moved to the driver). > > > > > > =A0 could you please confirm if your lirc and/or imon drivers wou= ld be > > > =A0 negatively affected by the proposed patches? > >=20 > > Will do so once I get them wedged in on top. >=20 > Got it all merged and compiling, but not yet runtime tested. Compilin= g > alone sheds some light on things though... >=20 > So this definitely negatively impacts my ir-core-to-lirc_dev > (ir-lirc-codec.c) bridge driver, as it was doing the lirc_dev device > registration work in its register function. However, if (after your > patchset) we add a new pair of callbacks replacing raw_register and > raw_unregister, which are optional, that work could be done there ins= tead, > so I don't think this is an insurmountable obstacle for the lirc bits= =2E While I'm not sure exactly what callbacks you're suggesting, it still=20 sounds like the callbacks would have the exact same problems that the=20 current code has (i.e. the decoder will be blissfully unaware of=20 hardware which exists before the decoder is loaded). Right? > As for the imon driver, the modprobe parameter in question (iirc) was > already removed from the driver, as its functionality is replaced by > implementing a change_protocol callback. However, there's a request t= o > add it (or something like it) back to the driver to allow disabling t= he > IR part altogether, and there are a few other modparams that might be > better suited as sysfs entries. However, its actually not relevant to= the > case of registering raw protocol handlers, as the imon devices do the= ir > decoding in hardware. I can see the possibility for protocol-specific > knobs in sysfs though. But I think the same optional callbacks I'd us= e to > keep the lirc bits working could also be used for this. Can't think o= f a > good name for these yet, probably need more coffee first... ;) But those sysfs entries wouldn't be=20 per-decoder-per-hardware-device....they'd just be=20 per-hardware-device...right? --=20 David H=E4rdeman -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html