From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Eric Miao <eric.y.miao@gmail.com>
Cc: Luotao Fu <l.fu@pengutronix.de>,
Marek Vasut <marek.vasut@gmail.com>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH V2] matrix_keypad: add support for clustered irq
Date: Thu, 10 Jun 2010 12:32:43 -0700 [thread overview]
Message-ID: <201006101232.43598.dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <AANLkTikzzqx0mJM6cjqdm_n8i3F4lCdaAf2xkpQ_havX@mail.gmail.com>
On Thursday, May 27, 2010 08:14:50 am Eric Miao wrote:
> On Thu, May 27, 2010 at 2:43 PM, Luotao Fu <l.fu@pengutronix.de> wrote:
> > This one adds support of a combined irq source for the whole matrix keypad.
> > This can be useful if all rows and columns of the keypad are e.g. connected
> > to a GPIO expander, which only has one interrupt line for all events on
> > every single GPIO.
> >
> > Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
>
> I feel OK. Acked-by: Eric Miao <eric.y.miao@gmail.com>
>
> > ---
> > V2 Changes:
> > * create separate functions for suspend/resume calls.
> > * add bool flag to signal enable/disable state of all gpios.
> > * add spinlock to suspend and resume callbacks.
The spinlock is not needed, it should be OK to get interrupted in the middle
of setting up wakeup sources. The enable/disable irq is different as if we
get interrupted in the middle of the process our counters will get messed
up.
Fixed a few compile warnings and applied for .36.
Thanks.
--
Dmitry
prev parent reply other threads:[~2010-06-10 19:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 13:57 [PATCH] matrix_keypad: add support for clustered irq Luotao Fu
2010-05-26 14:29 ` Eric Miao
2010-05-26 14:38 ` Luotao Fu
2010-05-27 6:43 ` [PATCH V2] " Luotao Fu
2010-05-27 15:14 ` Eric Miao
2010-06-10 19:32 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006101232.43598.dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=eric.y.miao@gmail.com \
--cc=l.fu@pengutronix.de \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.vasut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).