From: Wolfram Sang <w.sang@pengutronix.de>
To: Luotao Fu <l.fu@pengutronix.de>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] mfd: add STMPE811 core support
Date: Fri, 11 Jun 2010 15:28:06 +0200 [thread overview]
Message-ID: <20100611132806.GA5197@pengutronix.de> (raw)
In-Reply-To: <1276251195-22981-2-git-send-email-l.fu@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 352 bytes --]
Hi Fu,
> +err_free:
> + mutex_destroy(&stm->io_lock);
> + i2c_set_clientdata(client, NULL);
Please drop the clientdata line; the core clears the pointer now.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2010-06-11 13:28 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-11 10:13 Patch serie for STMPE811 Luotao Fu
2010-06-11 10:13 ` [PATCH 1/3] mfd: add STMPE811 core support Luotao Fu
2010-06-11 11:03 ` Jonathan Cameron
2010-06-11 11:33 ` Luotao Fu
2010-06-11 11:13 ` Mark Brown
2010-06-11 11:38 ` Luotao Fu
2010-06-11 13:28 ` Wolfram Sang [this message]
2010-06-11 10:13 ` [PATCH 2/3] gpio: add STMPE811 gpio controller support Luotao Fu
2010-06-11 10:13 ` [PATCH 3/3] input: STMPE811 touch " Luotao Fu
2010-06-11 11:21 ` Mark Brown
2010-06-11 11:45 ` Luotao Fu
2010-06-14 10:32 ` Patch serie for STMPE811 [V2] Luotao Fu
2010-06-15 9:00 ` Patch serie for STMPE811 [V3] Luotao Fu
2010-06-15 9:00 ` [PATCH 1/3 V3] mfd: add STMPE811 core support Luotao Fu
2010-06-15 14:59 ` Mark Brown
2010-06-15 9:00 ` [PATCH 2/3 V3] gpio: add STMPE811 gpio controller support Luotao Fu
2010-06-15 9:00 ` [PATCH 3/3 V3] input: STMPE811 touch " Luotao Fu
2010-06-14 10:32 ` [PATCH 1/3 V2] mfd: add STMPE811 core support Luotao Fu
2010-06-14 11:50 ` Mark Brown
2010-06-14 12:04 ` Luotao Fu
2010-06-14 10:32 ` [PATCH 2/3 V2] gpio: add STMPE811 gpio controller support Luotao Fu
2010-06-14 11:51 ` Mark Brown
2010-06-14 12:09 ` Luotao Fu
2010-06-14 12:13 ` Mark Brown
[not found] ` <20100614121349.GC14604@rakim.wolfsonmicro.main>
2010-06-14 12:28 ` Luotao Fu
2010-06-14 12:34 ` Mark Brown
2010-06-14 10:32 ` [PATCH 3/3 V2] input: STMPE811 touch " Luotao Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100611132806.GA5197@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=akpm@linux-foundation.org \
--cc=dmitry.torokhov@gmail.com \
--cc=l.fu@pengutronix.de \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).