From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luotao Fu Subject: Re: [PATCH 2/3 V2] gpio: add STMPE811 gpio controller support Date: Mon, 14 Jun 2010 14:28:53 +0200 Message-ID: <20100614122853.GC12027@pengutronix.de> References: <1276251195-22981-1-git-send-email-l.fu@pengutronix.de> <1276511558-27121-3-git-send-email-l.fu@pengutronix.de> <20100614115123.GB14604@rakim.wolfsonmicro.main> <20100614120943.GB12027@pengutronix.de> <20100614121349.GC14604@rakim.wolfsonmicro.main> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5G06lTa6Jq83wMTw" Return-path: Received: from metis.ext.pengutronix.de ([92.198.50.35]:53191 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751602Ab0FNM3B (ORCPT ); Mon, 14 Jun 2010 08:29:01 -0400 Content-Disposition: inline In-Reply-To: <20100614121349.GC14604@rakim.wolfsonmicro.main> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Mark Brown Cc: Luotao Fu , Samuel Ortiz , Dmitry Torokhov , Andrew Morton , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org --5G06lTa6Jq83wMTw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Mark, On Mon, Jun 14, 2010 at 01:13:49PM +0100, Mark Brown wrote: > On Mon, Jun 14, 2010 at 02:09:43PM +0200, Luotao Fu wrote: > > On Mon, Jun 14, 2010 at 12:51:23PM +0100, Mark Brown wrote: >=20 > > > Assuming you're able to do interrupts on the GPIOs you should now be > > > able to implement to_irq() as well. >=20 > > The chip can indeed generate irqs on the GPIO line. I, however, kept out > > the irq stuff for now because i want to get the core functionalies done > > for this turn. I'd like to add the irq stuff with a separate patch late= r. >=20 > It should be a trivial function - it just does a mapping from a GPIO > number to an IRQ number. right, to_irq is simple. However, there're some more stuff necessary for gpio irq on this chip, since it has separate registers for GPIO interrupt control and status. A further gpio chip might be needed needed to get the stuff done. Hence I'd like to push out the most importatn core funcationalities out for the first turn before I take a deeper look into other stuffs. thanks cheers Luotao Fu --=20 Pengutronix e.K. | Dipl.-Ing. Luotao Fu | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --5G06lTa6Jq83wMTw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkwWIIUACgkQkLuxfMCkDTYMzgCeP1B2mifNmw+2BZXSxYGvScIB CFoAnjtz7Vy7u36qYJXIrfH0fVZHrO9X =LpwK -----END PGP SIGNATURE----- --5G06lTa6Jq83wMTw--