From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH RFC 2/3] input: wm97xx: set GPIOs with AC97 GPIO busops if implemented Date: Tue, 15 Jun 2010 17:08:03 +0100 Message-ID: <20100615160802.GL14510@rakim.wolfsonmicro.main> References: <1276617347-3522-1-git-send-email-manuel.lauss@googlemail.com> <1276617347-3522-3-git-send-email-manuel.lauss@googlemail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from opensource.wolfsonmicro.com ([80.75.67.52]:34661 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753559Ab0FOQIE (ORCPT ); Tue, 15 Jun 2010 12:08:04 -0400 Content-Disposition: inline In-Reply-To: <1276617347-3522-3-git-send-email-manuel.lauss@googlemail.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Manuel Lauss Cc: alsa-devel@vger.kernel.org, linux-input@vger.kernel.org, Takashi Iwai , Liam Girdwood On Tue, Jun 15, 2010 at 05:55:46PM +0200, Manuel Lauss wrote: > If the AC97 controller implements the ->setgpio callback, use it. > Some codecs (i.e. WM9712) only accept GPIO data through AC97 slot 12. > > Signed-off-by: Manuel Lauss It seems like it'd be easier to just do this as a generic AC'97 thing rather than adding it to the WM97xx driver - that way any CODEC that has GPIO support can use it, we don't have to add custom per-CODEC GPIO APIs. If you're using the WM97xx-specific code you're already doing something custom so it's not much loss to use a generic thing. Like I said in reply to the previous mail super bonus fun points for doing it in terms of gpiolib.