From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Manuel Lauss <manuel.lauss@googlemail.com>
Cc: Takashi Iwai <tiwai@suse.de>,
alsa-devel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH RFC 1/3] sound: ac97: Add GPIO manipulation hooks
Date: Wed, 16 Jun 2010 13:52:13 +0100 [thread overview]
Message-ID: <20100616125213.GA24491@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <AANLkTik3PHoo-1Is-yrzzTRjeH9G7v8LUgqxBzgVRQDi@mail.gmail.com>
On Wed, Jun 16, 2010 at 10:00:19AM +0200, Manuel Lauss wrote:
> On Wed, Jun 16, 2010 at 9:55 AM, Takashi Iwai <tiwai@suse.de> wrote:
> >> > + void (*setgpio) (struct snd_ac97 *ac97, unsigned short gpio);
> >> > + unsigned short (*getgpio) (struct snd_ac97 *ac97);
> > Can this be handled simply in read/write callbacks in the controller
> > side? In callbacks, you can check whether reg == AC97_GPIO_STATUS and
> > handle differently for such an access.
> Interesting Idea, and as a bonus requires no changes to the wm97xx code.
The only thing that worries me there is any non-standard behavior the
chip may implement - it may actually want a write to that register for
some extended functionality.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-06-16 12:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-15 15:55 [PATCH RFC 0/3] WM97xx AC97 GPIO support Manuel Lauss
2010-06-15 15:55 ` [PATCH RFC 1/3] sound: ac97: Add GPIO manipulation hooks Manuel Lauss
2010-06-15 16:02 ` Mark Brown
2010-06-15 16:13 ` Manuel Lauss
2010-06-16 7:55 ` Takashi Iwai
2010-06-16 8:00 ` Manuel Lauss
2010-06-16 12:52 ` Mark Brown [this message]
2010-06-15 15:55 ` [PATCH RFC 2/3] input: wm97xx: set GPIOs with AC97 GPIO busops if implemented Manuel Lauss
2010-06-15 16:08 ` Mark Brown
2010-06-15 16:17 ` Manuel Lauss
2010-06-15 16:27 ` Mark Brown
2010-06-15 15:55 ` [PATCH RFC 3/3] sound: asoc: au1x: implement AC97 GPIO access Manuel Lauss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100616125213.GA24491@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=manuel.lauss@googlemail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).