From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 1/2] Input: ads7846 - allow specifying irq trigger type in platform data Date: Mon, 28 Jun 2010 01:32:08 -0700 Message-ID: <20100628083208.GD25287@core.coreip.homeip.net> References: <1272630181-5364-1-git-send-email-agust@denx.de> <20100531212820.322d5bfd@wker> <20100625113534.77524c85@wker> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-px0-f174.google.com ([209.85.212.174]:48678 "EHLO mail-px0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754833Ab0F1IcO (ORCPT ); Mon, 28 Jun 2010 04:32:14 -0400 Received: by pxi8 with SMTP id 8so1642725pxi.19 for ; Mon, 28 Jun 2010 01:32:14 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20100625113534.77524c85@wker> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Anatolij Gustschin Cc: linux-input@vger.kernel.org, Detlev Zundel On Fri, Jun 25, 2010 at 11:35:34AM +0200, Anatolij Gustschin wrote: > On Mon, 31 May 2010 21:28:20 +0200 > Anatolij Gustschin wrote: > > > Hi Dmitry, > > > > On Fri, 30 Apr 2010 14:23:00 +0200 > > Anatolij Gustschin wrote: > > > > > On some platforms, for example with GPIO interrupts > > > on mpc5121, it is not possible to configure falling edge > > > interrupts. > > > > > > Specifying irq trigger type in platform data structure > > > allows using ads7846 driver on such platforms. > > > > > > Signed-off-by: Anatolij Gustschin > > > --- > > > drivers/input/touchscreen/ads7846.c | 5 ++++- > > > include/linux/spi/ads7846.h | 1 + > > > 2 files changed, 5 insertions(+), 1 deletions(-) > > > > Any comments on these patches? > > Ping? The patches still apply on top of the input.git/next branch. > I applied the first one (however changed irq_trigger to be unsigned long) however I'd like better changelog for 7845 changes. Thanks. -- Dmitry