From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Daniel Mack <daniel@caiaq.de>
Cc: Dmitriy Vasil'ev <tech@digiton.ru>, linux-input@vger.kernel.org
Subject: Re: rotary encoder
Date: Mon, 28 Jun 2010 11:22:26 -0700 [thread overview]
Message-ID: <20100628182225.GB7427@core.coreip.homeip.net> (raw)
In-Reply-To: <20100617120005.GF17833@buzzloop.caiaq.de>
On Thu, Jun 17, 2010 at 02:00:05PM +0200, Daniel Mack wrote:
> On Thu, Jun 17, 2010 at 03:55:05PM +0400, Dmitriy Vasil'ev wrote:
> > diff utility make this strange result.
> >
> > I added only one structure, debouncing timer and handle EV_KEY type.
>
> Yo, and a proper patch generated by a well working tool would show
> exactly this.
>
> > You can see difference with "total commander" and it command
> > "Files->Compare by content..."
>
> I don't have this tool. I don't even have Windows. Developers in the
> kernel community have agreed to share patches as unified diffs, and your
> contribution really shouldn't make any difference.
>
> As a matter of fact, the tool that just gets it right all the way is
> git, and I can only encourage you to get your head around it and use it.
>
> Also, please read Documentation/SubmittingPatches, which also describes
> the process of collaboration very well.
>
It looks like Dmitriy's editor of choice happily messed up all
whitespace in the original version converting tabs to spaces.
Pity as it makes the result completely unusable.
--
Dmitry
next prev parent reply other threads:[~2010-06-28 18:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7A46ED6446BE4CF7AAC51205F1B5A88B@tech>
2010-06-02 13:20 ` rotary encoder Daniel Mack
[not found] ` <BA41AF5D757645AD94502E4B0A29158A@tech>
2010-06-02 13:52 ` Daniel Mack
[not found] ` <888FDE7800AB4E278ED6DF185FEDC869@tech>
2010-06-17 10:10 ` Daniel Mack
[not found] ` <B221BAA24375436992F7587DF15BB812@tech>
2010-06-17 11:21 ` Daniel Mack
2010-06-17 11:29 ` Dmitriy Vasil'ev
2010-06-17 11:37 ` Daniel Mack
2010-06-17 11:55 ` Dmitriy Vasil'ev
2010-06-17 12:00 ` Daniel Mack
2010-06-28 18:22 ` Dmitry Torokhov [this message]
2010-06-28 18:32 ` Daniel Mack
2010-06-29 15:06 ` Dmitriy Vasil'ev
2010-06-30 8:40 ` Dmitry Torokhov
2010-06-30 9:33 ` Dmitriy Vasil'ev
2010-06-30 19:54 ` Dmitry Torokhov
2013-05-21 8:38 rotary_encoder Christian Gmeiner
2013-05-21 19:13 ` rotary_encoder Dmitry Torokhov
[not found] <4BE96550.9020800@solutionsradio.com>
2010-05-11 14:17 ` Rotary encoder Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100628182225.GB7427@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=daniel@caiaq.de \
--cc=linux-input@vger.kernel.org \
--cc=tech@digiton.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).