From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: rotary encoder Date: Mon, 28 Jun 2010 11:22:26 -0700 Message-ID: <20100628182225.GB7427@core.coreip.homeip.net> References: <20100602135251.GC2695@buzzloop.caiaq.de> <888FDE7800AB4E278ED6DF185FEDC869@tech> <20100617101021.GB17833@buzzloop.caiaq.de> <20100617112135.GC17833@buzzloop.caiaq.de> <20100617113725.GD17833@buzzloop.caiaq.de> <1E284238E08046EFA4038129CEA2527F@tech> <20100617120005.GF17833@buzzloop.caiaq.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-px0-f174.google.com ([209.85.212.174]:64770 "EHLO mail-px0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751259Ab0F1S2F (ORCPT ); Mon, 28 Jun 2010 14:28:05 -0400 Received: by pxi8 with SMTP id 8so1928220pxi.19 for ; Mon, 28 Jun 2010 11:28:03 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20100617120005.GF17833@buzzloop.caiaq.de> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Daniel Mack Cc: Dmitriy Vasil'ev , linux-input@vger.kernel.org On Thu, Jun 17, 2010 at 02:00:05PM +0200, Daniel Mack wrote: > On Thu, Jun 17, 2010 at 03:55:05PM +0400, Dmitriy Vasil'ev wrote: > > diff utility make this strange result. > > > > I added only one structure, debouncing timer and handle EV_KEY type. > > Yo, and a proper patch generated by a well working tool would show > exactly this. > > > You can see difference with "total commander" and it command > > "Files->Compare by content..." > > I don't have this tool. I don't even have Windows. Developers in the > kernel community have agreed to share patches as unified diffs, and your > contribution really shouldn't make any difference. > > As a matter of fact, the tool that just gets it right all the way is > git, and I can only encourage you to get your head around it and use it. > > Also, please read Documentation/SubmittingPatches, which also describes > the process of collaboration very well. > It looks like Dmitriy's editor of choice happily messed up all whitespace in the original version converting tabs to spaces. Pity as it makes the result completely unusable. -- Dmitry