From: Anatolij Gustschin <agust@denx.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, Detlev Zundel <dzu@denx.de>
Subject: Re: [PATCH 1/2] Input: ads7846 - allow specifying irq trigger type in platform data
Date: Tue, 29 Jun 2010 09:24:20 +0200 [thread overview]
Message-ID: <20100629092420.0f432622@wker> (raw)
In-Reply-To: <20100628083208.GD25287@core.coreip.homeip.net>
On Mon, 28 Jun 2010 01:32:08 -0700
Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> On Fri, Jun 25, 2010 at 11:35:34AM +0200, Anatolij Gustschin wrote:
> > On Mon, 31 May 2010 21:28:20 +0200
> > Anatolij Gustschin <agust@denx.de> wrote:
> >
> > > Hi Dmitry,
> > >
> > > On Fri, 30 Apr 2010 14:23:00 +0200
> > > Anatolij Gustschin <agust@denx.de> wrote:
> > >
> > > > On some platforms, for example with GPIO interrupts
> > > > on mpc5121, it is not possible to configure falling edge
> > > > interrupts.
> > > >
> > > > Specifying irq trigger type in platform data structure
> > > > allows using ads7846 driver on such platforms.
> > > >
> > > > Signed-off-by: Anatolij Gustschin <agust@denx.de>
> > > > ---
> > > > drivers/input/touchscreen/ads7846.c | 5 ++++-
> > > > include/linux/spi/ads7846.h | 1 +
> > > > 2 files changed, 5 insertions(+), 1 deletions(-)
> > >
> > > Any comments on these patches?
> >
> > Ping? The patches still apply on top of the input.git/next branch.
> >
>
> I applied the first one (however changed irq_trigger to be unsigned
> long) however I'd like better changelog for 7845 changes.
Thanks. I'll submit v2 patch for 7845 changes with a better
changelog soon.
Anatolij
prev parent reply other threads:[~2010-06-29 7:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-30 12:23 [PATCH 1/2] Input: ads7846 - allow specifying irq trigger type in platform data Anatolij Gustschin
2010-04-30 12:23 ` [PATCH 2/2] Input: ads7846 - extend the driver for ads7845 controller support Anatolij Gustschin
2010-06-29 9:29 ` [PATCH v2 " Anatolij Gustschin
2010-06-30 8:18 ` Dmitry Torokhov
2010-06-30 8:45 ` Anatolij Gustschin
2010-07-01 11:23 ` Anatolij Gustschin
2010-07-01 11:26 ` [PATCH] Input: ads7846 - do not allow altering platform data Anatolij Gustschin
2010-07-01 16:10 ` Dmitry Torokhov
2010-05-31 19:28 ` [PATCH 1/2] Input: ads7846 - allow specifying irq trigger type in " Anatolij Gustschin
2010-06-25 9:35 ` Anatolij Gustschin
2010-06-28 8:32 ` Dmitry Torokhov
2010-06-29 7:24 ` Anatolij Gustschin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100629092420.0f432622@wker \
--to=agust@denx.de \
--cc=dmitry.torokhov@gmail.com \
--cc=dzu@denx.de \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).