* [patch] TC4UM driver for linux-input [not found] ` <20100603075720.GQ26052@ibawizard.net> @ 2010-06-10 9:33 ` Roger Pueyo 2010-06-11 7:40 ` [PATCH 1/2] Input: usbtouchscreen - add support for ET&T TC4UM touchscreen controller Petr Štetiar 1 sibling, 0 replies; 12+ messages in thread From: Roger Pueyo @ 2010-06-10 9:33 UTC (permalink / raw) To: linux-input [-- Attachment #1: Type: text/plain, Size: 580 bytes --] Hi, These patches are for the ET&T TC4UM usb touchscreen. They are by Petr Štetiar. They are the same as his previously written TC5UH, just changing the hardware ID. I've tested them against kernel 2.6.34 with X.org 1.7 and work flawlessly with evdev driver. Let me know any suggestions, please. Roger ---------- Forwarded message ---------- From: Petr Štetiar <@> Date: 2010/6/3 Subject: Re: TC4UM driver for linux-input To: Roger Pueyo <@> Cc: Petr Štetiar <@> Please can you test attached patches? Does they work for you? Thank you. -- ynezz [-- Attachment #2: 0001-Input-usbtouchscreen-add-support-for-ET-T-TC4UM-t.patch --] [-- Type: text/x-diff, Size: 3280 bytes --] From 373b01f6f11d23812510026b47464e5cd4cb5593 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Petr=20=C5=A0tetiar?= <ynezz@true.cz> Date: Thu, 3 Jun 2010 09:48:00 +0200 Subject: [PATCH] Input: usbtouchscreen - add support for ET&T TC4UM touchscreen controller MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit This patch adds support for the ET&T TC4UM 4-wire USB touchscreen controller and tries to reuse code for TC5UH controller in kernel already. Data interface is same. Tested-by: Roger Pueyo Centelles <rogerpueyo@rogerpueyo.com> Signed-off-by: Petr Štetiar <ynezz@true.cz> --- drivers/input/touchscreen/Kconfig | 4 ++-- drivers/input/touchscreen/usbtouchscreen.c | 21 ++++++++++++--------- 2 files changed, 14 insertions(+), 11 deletions(-) diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig index 6703c6b..4250718 100644 --- a/drivers/input/touchscreen/Kconfig +++ b/drivers/input/touchscreen/Kconfig @@ -540,9 +540,9 @@ config TOUCHSCREEN_USB_ZYTRONIC bool "Zytronic controller" if EMBEDDED depends on TOUCHSCREEN_USB_COMPOSITE -config TOUCHSCREEN_USB_ETT_TC5UH +config TOUCHSCREEN_USB_ETT_TC45USB default y - bool "ET&T TC5UH touchscreen controler support" if EMBEDDED + bool "ET&T USB series TC4UM/TC5UH touchscreen controler support" if EMBEDDED depends on TOUCHSCREEN_USB_COMPOSITE config TOUCHSCREEN_USB_NEXIO diff --git a/drivers/input/touchscreen/usbtouchscreen.c b/drivers/input/touchscreen/usbtouchscreen.c index 567d572..3244542 100644 --- a/drivers/input/touchscreen/usbtouchscreen.c +++ b/drivers/input/touchscreen/usbtouchscreen.c @@ -135,7 +135,7 @@ enum { DEVTYPE_JASTEC, DEVTYPE_E2I, DEVTYPE_ZYTRONIC, - DEVTYPE_TC5UH, + DEVTYPE_TC45USB, DEVTYPE_NEXIO, }; @@ -222,8 +222,11 @@ static const struct usb_device_id usbtouch_devices[] = { {USB_DEVICE(0x14c8, 0x0003), .driver_info = DEVTYPE_ZYTRONIC}, #endif -#ifdef CONFIG_TOUCHSCREEN_USB_ETT_TC5UH - {USB_DEVICE(0x0664, 0x0309), .driver_info = DEVTYPE_TC5UH}, +#ifdef CONFIG_TOUCHSCREEN_USB_ETT_TC45USB + /* TC5UH */ + {USB_DEVICE(0x0664, 0x0309), .driver_info = DEVTYPE_TC45USB}, + /* TC4UM */ + {USB_DEVICE(0x0664, 0x0306), .driver_info = DEVTYPE_TC45USB}, #endif #ifdef CONFIG_TOUCHSCREEN_USB_NEXIO @@ -574,10 +577,10 @@ static int irtouch_read_data(struct usbtouch_usb *dev, unsigned char *pkt) #endif /***************************************************************************** - * ET&T TC5UH part + * ET&T TC5UH/TC4UM part */ -#ifdef CONFIG_TOUCHSCREEN_USB_ETT_TC5UH -static int tc5uh_read_data(struct usbtouch_usb *dev, unsigned char *pkt) +#ifdef CONFIG_TOUCHSCREEN_USB_ETT_TC45USB +static int tc45usb_read_data(struct usbtouch_usb *dev, unsigned char *pkt) { dev->x = ((pkt[2] & 0x0F) << 8) | pkt[1]; dev->y = ((pkt[4] & 0x0F) << 8) | pkt[3]; @@ -1104,14 +1107,14 @@ static struct usbtouch_device_info usbtouch_dev_info[] = { }, #endif -#ifdef CONFIG_TOUCHSCREEN_USB_ETT_TC5UH - [DEVTYPE_TC5UH] = { +#ifdef CONFIG_TOUCHSCREEN_USB_ETT_TC45USB + [DEVTYPE_TC45USB] = { .min_xc = 0x0, .max_xc = 0x0fff, .min_yc = 0x0, .max_yc = 0x0fff, .rept_size = 5, - .read_data = tc5uh_read_data, + .read_data = tc45usb_read_data, }, #endif -- 1.5.6.5 [-- Attachment #3: 0002-HID-blacklist-ET-T-TC4UH-touchscreen-controller.patch --] [-- Type: text/x-diff, Size: 1549 bytes --] From 6fcc9687b8edbd7df70bc4868e8a849eddd3b4fe Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Petr=20=C5=A0tetiar?= <ynezz@true.cz> Date: Thu, 3 Jun 2010 09:53:49 +0200 Subject: [PATCH] HID: blacklist ET&T TC4UH touchscreen controller MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Signed-off-by: Petr Štetiar <ynezz@true.cz> --- drivers/hid/hid-core.c | 1 + drivers/hid/hid-ids.h | 1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index aa0f7dc..a35f8be 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -1568,6 +1568,7 @@ static const struct hid_device_id hid_ignore_list[] = { { HID_USB_DEVICE(USB_VENDOR_ID_DELORME, USB_DEVICE_ID_DELORME_EM_LT20) }, { HID_USB_DEVICE(USB_VENDOR_ID_ESSENTIAL_REALITY, USB_DEVICE_ID_ESSENTIAL_REALITY_P5) }, { HID_USB_DEVICE(USB_VENDOR_ID_ETT, USB_DEVICE_ID_TC5UH) }, + { HID_USB_DEVICE(USB_VENDOR_ID_ETT, USB_DEVICE_ID_TC4UM) }, { HID_USB_DEVICE(USB_VENDOR_ID_GENERAL_TOUCH, 0x0001) }, { HID_USB_DEVICE(USB_VENDOR_ID_GENERAL_TOUCH, 0x0002) }, { HID_USB_DEVICE(USB_VENDOR_ID_GENERAL_TOUCH, 0x0003) }, diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index 6af77ed..fad4cb0 100644 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h @@ -197,6 +197,7 @@ #define USB_VENDOR_ID_ETT 0x0664 #define USB_DEVICE_ID_TC5UH 0x0309 +#define USB_DEVICE_ID_TC4UM 0x0306 #define USB_VENDOR_ID_EZKEY 0x0518 #define USB_DEVICE_ID_BTC_8193 0x0002 -- 1.5.6.5 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 1/2] Input: usbtouchscreen - add support for ET&T TC4UM touchscreen controller [not found] ` <20100603075720.GQ26052@ibawizard.net> 2010-06-10 9:33 ` [patch] TC4UM driver for linux-input Roger Pueyo @ 2010-06-11 7:40 ` Petr Štetiar 2010-06-11 7:40 ` [PATCH 2/2] HID: blacklist ET&T TC4UH " Petr Štetiar 2010-06-28 9:19 ` [PATCH 1/2] Input: usbtouchscreen - add support for ET&T TC4UM " Petr Štetiar 1 sibling, 2 replies; 12+ messages in thread From: Petr Štetiar @ 2010-06-11 7:40 UTC (permalink / raw) To: linux-input; +Cc: Dmitry Torokhov, Jiri Kosina, ynezz This patch adds support for the ET&T TC4UM 4-wire USB touchscreen controller and tries to reuse the bits for TC5UH controller in kernel already. Data interface is same. Tested-by: Roger Pueyo Centelles <rogerpueyo@rogerpueyo.com> Signed-off-by: Petr Štetiar <ynezz@true.cz> --- drivers/input/touchscreen/Kconfig | 4 ++-- drivers/input/touchscreen/usbtouchscreen.c | 21 ++++++++++++--------- 2 files changed, 14 insertions(+), 11 deletions(-) diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig index 3b9d5e2..e835f04 100644 --- a/drivers/input/touchscreen/Kconfig +++ b/drivers/input/touchscreen/Kconfig @@ -540,9 +540,9 @@ config TOUCHSCREEN_USB_ZYTRONIC bool "Zytronic controller" if EMBEDDED depends on TOUCHSCREEN_USB_COMPOSITE -config TOUCHSCREEN_USB_ETT_TC5UH +config TOUCHSCREEN_USB_ETT_TC45USB default y - bool "ET&T TC5UH touchscreen controler support" if EMBEDDED + bool "ET&T USB series TC4UM/TC5UH touchscreen controler support" if EMBEDDED depends on TOUCHSCREEN_USB_COMPOSITE config TOUCHSCREEN_USB_NEXIO diff --git a/drivers/input/touchscreen/usbtouchscreen.c b/drivers/input/touchscreen/usbtouchscreen.c index 567d572..3244542 100644 --- a/drivers/input/touchscreen/usbtouchscreen.c +++ b/drivers/input/touchscreen/usbtouchscreen.c @@ -135,7 +135,7 @@ enum { DEVTYPE_JASTEC, DEVTYPE_E2I, DEVTYPE_ZYTRONIC, - DEVTYPE_TC5UH, + DEVTYPE_TC45USB, DEVTYPE_NEXIO, }; @@ -222,8 +222,11 @@ static const struct usb_device_id usbtouch_devices[] = { {USB_DEVICE(0x14c8, 0x0003), .driver_info = DEVTYPE_ZYTRONIC}, #endif -#ifdef CONFIG_TOUCHSCREEN_USB_ETT_TC5UH - {USB_DEVICE(0x0664, 0x0309), .driver_info = DEVTYPE_TC5UH}, +#ifdef CONFIG_TOUCHSCREEN_USB_ETT_TC45USB + /* TC5UH */ + {USB_DEVICE(0x0664, 0x0309), .driver_info = DEVTYPE_TC45USB}, + /* TC4UM */ + {USB_DEVICE(0x0664, 0x0306), .driver_info = DEVTYPE_TC45USB}, #endif #ifdef CONFIG_TOUCHSCREEN_USB_NEXIO @@ -574,10 +577,10 @@ static int irtouch_read_data(struct usbtouch_usb *dev, unsigned char *pkt) #endif /***************************************************************************** - * ET&T TC5UH part + * ET&T TC5UH/TC4UM part */ -#ifdef CONFIG_TOUCHSCREEN_USB_ETT_TC5UH -static int tc5uh_read_data(struct usbtouch_usb *dev, unsigned char *pkt) +#ifdef CONFIG_TOUCHSCREEN_USB_ETT_TC45USB +static int tc45usb_read_data(struct usbtouch_usb *dev, unsigned char *pkt) { dev->x = ((pkt[2] & 0x0F) << 8) | pkt[1]; dev->y = ((pkt[4] & 0x0F) << 8) | pkt[3]; @@ -1104,14 +1107,14 @@ static struct usbtouch_device_info usbtouch_dev_info[] = { }, #endif -#ifdef CONFIG_TOUCHSCREEN_USB_ETT_TC5UH - [DEVTYPE_TC5UH] = { +#ifdef CONFIG_TOUCHSCREEN_USB_ETT_TC45USB + [DEVTYPE_TC45USB] = { .min_xc = 0x0, .max_xc = 0x0fff, .min_yc = 0x0, .max_yc = 0x0fff, .rept_size = 5, - .read_data = tc5uh_read_data, + .read_data = tc45usb_read_data, }, #endif -- 1.5.6.5 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/2] HID: blacklist ET&T TC4UH touchscreen controller 2010-06-11 7:40 ` [PATCH 1/2] Input: usbtouchscreen - add support for ET&T TC4UM touchscreen controller Petr Štetiar @ 2010-06-11 7:40 ` Petr Štetiar 2010-06-11 7:55 ` Jiri Kosina 2010-06-28 9:19 ` [PATCH 1/2] Input: usbtouchscreen - add support for ET&T TC4UM " Petr Štetiar 1 sibling, 1 reply; 12+ messages in thread From: Petr Štetiar @ 2010-06-11 7:40 UTC (permalink / raw) To: linux-input; +Cc: Dmitry Torokhov, Jiri Kosina, ynezz Signed-off-by: Petr Štetiar <ynezz@true.cz> --- drivers/hid/hid-core.c | 1 + drivers/hid/hid-ids.h | 1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index aa0f7dc..a35f8be 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -1568,6 +1568,7 @@ static const struct hid_device_id hid_ignore_list[] = { { HID_USB_DEVICE(USB_VENDOR_ID_DELORME, USB_DEVICE_ID_DELORME_EM_LT20) }, { HID_USB_DEVICE(USB_VENDOR_ID_ESSENTIAL_REALITY, USB_DEVICE_ID_ESSENTIAL_REALITY_P5) }, { HID_USB_DEVICE(USB_VENDOR_ID_ETT, USB_DEVICE_ID_TC5UH) }, + { HID_USB_DEVICE(USB_VENDOR_ID_ETT, USB_DEVICE_ID_TC4UM) }, { HID_USB_DEVICE(USB_VENDOR_ID_GENERAL_TOUCH, 0x0001) }, { HID_USB_DEVICE(USB_VENDOR_ID_GENERAL_TOUCH, 0x0002) }, { HID_USB_DEVICE(USB_VENDOR_ID_GENERAL_TOUCH, 0x0003) }, diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index 6af77ed..fad4cb0 100644 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h @@ -197,6 +197,7 @@ #define USB_VENDOR_ID_ETT 0x0664 #define USB_DEVICE_ID_TC5UH 0x0309 +#define USB_DEVICE_ID_TC4UM 0x0306 #define USB_VENDOR_ID_EZKEY 0x0518 #define USB_DEVICE_ID_BTC_8193 0x0002 -- 1.5.6.5 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] HID: blacklist ET&T TC4UH touchscreen controller 2010-06-11 7:40 ` [PATCH 2/2] HID: blacklist ET&T TC4UH " Petr Štetiar @ 2010-06-11 7:55 ` Jiri Kosina 0 siblings, 0 replies; 12+ messages in thread From: Jiri Kosina @ 2010-06-11 7:55 UTC (permalink / raw) To: Petr Štetiar; +Cc: linux-input, Dmitry Torokhov On Fri, 11 Jun 2010, Petr Štetiar wrote: > Signed-off-by: Petr Štetiar <ynezz@true.cz> Dmitry, feel free to take this together with the usbtouchscreen driver changes and add Signed-off-by: Jiri Kosina <jkosina@suse.cz> to this patch in your tree. Thanks, -- Jiri Kosina SUSE Labs, Novell Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] Input: usbtouchscreen - add support for ET&T TC4UM touchscreen controller 2010-06-11 7:40 ` [PATCH 1/2] Input: usbtouchscreen - add support for ET&T TC4UM touchscreen controller Petr Štetiar 2010-06-11 7:40 ` [PATCH 2/2] HID: blacklist ET&T TC4UH " Petr Štetiar @ 2010-06-28 9:19 ` Petr Štetiar 2010-06-28 16:46 ` Dmitry Torokhov 1 sibling, 1 reply; 12+ messages in thread From: Petr Štetiar @ 2010-06-28 9:19 UTC (permalink / raw) To: Dmitry Torokhov; +Cc: linux-input, Petr Štetiar, Jiri Kosina Petr Štetiar <ynezz@true.cz> [2010-06-11 09:40:53]: > This patch adds support for the ET&T TC4UM 4-wire USB touchscreen controller > and tries to reuse the bits for TC5UH controller in kernel already. Data > interface is same. > > Tested-by: Roger Pueyo Centelles <rogerpueyo@rogerpueyo.com> > Signed-off-by: Petr Štetiar <ynezz@true.cz> > --- Hi Dmitry, you're probably overloaded, so just a small ping :-) Thanks. -- ynezz -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] Input: usbtouchscreen - add support for ET&T TC4UM touchscreen controller 2010-06-28 9:19 ` [PATCH 1/2] Input: usbtouchscreen - add support for ET&T TC4UM " Petr Štetiar @ 2010-06-28 16:46 ` Dmitry Torokhov 2010-06-30 7:16 ` usbtouchscreen - runtime PM patches testing [Was: [PATCH 1/2] Input: usbtouchscreen - add support for ET&T TC4UM touchscreen controller] Petr Štetiar 0 siblings, 1 reply; 12+ messages in thread From: Dmitry Torokhov @ 2010-06-28 16:46 UTC (permalink / raw) To: Petr Štetiar; +Cc: linux-input, Jiri Kosina On Mon, Jun 28, 2010 at 11:19:59AM +0200, Petr Štetiar wrote: > Petr Štetiar <ynezz@true.cz> [2010-06-11 09:40:53]: > > > This patch adds support for the ET&T TC4UM 4-wire USB touchscreen controller > > and tries to reuse the bits for TC5UH controller in kernel already. Data > > interface is same. > > > > Tested-by: Roger Pueyo Centelles <rogerpueyo@rogerpueyo.com> > > Signed-off-by: Petr Štetiar <ynezz@true.cz> > > --- > > Hi Dmitry, > > you're probably overloaded, so just a small ping :-) Thanks. > Hi Petr, Applied to 'next' branch (for .36). But I was wondering - could you please try the runtime PM patches to usebtouchscreen posted by Oliver Neukum on the linux-input list? I'd really like to apply them but I'd like to have them tested first. Thank you! -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 12+ messages in thread
* usbtouchscreen - runtime PM patches testing [Was: [PATCH 1/2] Input: usbtouchscreen - add support for ET&T TC4UM touchscreen controller] 2010-06-28 16:46 ` Dmitry Torokhov @ 2010-06-30 7:16 ` Petr Štetiar 2010-06-30 7:48 ` Dmitry Torokhov 2010-06-30 13:04 ` Oliver Neukum 0 siblings, 2 replies; 12+ messages in thread From: Petr Štetiar @ 2010-06-30 7:16 UTC (permalink / raw) To: Dmitry Torokhov; +Cc: Petr Štetiar, linux-input, Oliver Neukum Dmitry Torokhov <dmitry.torokhov@gmail.com> [2010-06-28 09:46:03]: > Applied to 'next' branch (for .36). But I was wondering - could you > please try the runtime PM patches to usebtouchscreen posted by Oliver > Neukum on the linux-input list? I'd really like to apply them but > I'd like to have them tested first. Thank you for applying my patches. Well, I've now only broken touchscreen, which have only 4-wires or so working, but I think, that it should be enough for PM testing. What kind of testing do you need, just few suspend & resume cycles? CC-ing Oliver also. -- ynezz ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: usbtouchscreen - runtime PM patches testing [Was: [PATCH 1/2] Input: usbtouchscreen - add support for ET&T TC4UM touchscreen controller] 2010-06-30 7:16 ` usbtouchscreen - runtime PM patches testing [Was: [PATCH 1/2] Input: usbtouchscreen - add support for ET&T TC4UM touchscreen controller] Petr Štetiar @ 2010-06-30 7:48 ` Dmitry Torokhov 2010-06-30 13:04 ` Oliver Neukum 1 sibling, 0 replies; 12+ messages in thread From: Dmitry Torokhov @ 2010-06-30 7:48 UTC (permalink / raw) To: Petr Štetiar; +Cc: linux-input, Oliver Neukum On Wed, Jun 30, 2010 at 09:16:35AM +0200, Petr Štetiar wrote: > Dmitry Torokhov <dmitry.torokhov@gmail.com> [2010-06-28 09:46:03]: > > > Applied to 'next' branch (for .36). But I was wondering - could you > > please try the runtime PM patches to usebtouchscreen posted by Oliver > > Neukum on the linux-input list? I'd really like to apply them but > > I'd like to have them tested first. > > Thank you for applying my patches. Well, I've now only broken touchscreen, > which have only 4-wires or so working, but I think, that it should be enough > for PM testing. What kind of testing do you need, just few suspend & resume > cycles? CC-ing Oliver also. > Not breaking stuff by default is good enough for me but Oliver should be able to tell what exactly tests he'd like to see. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: usbtouchscreen - runtime PM patches testing [Was: [PATCH 1/2] Input: usbtouchscreen - add support for ET&T TC4UM touchscreen controller] 2010-06-30 7:16 ` usbtouchscreen - runtime PM patches testing [Was: [PATCH 1/2] Input: usbtouchscreen - add support for ET&T TC4UM touchscreen controller] Petr Štetiar 2010-06-30 7:48 ` Dmitry Torokhov @ 2010-06-30 13:04 ` Oliver Neukum 2010-07-14 10:43 ` Petr Štetiar 1 sibling, 1 reply; 12+ messages in thread From: Oliver Neukum @ 2010-06-30 13:04 UTC (permalink / raw) To: Petr Štetiar; +Cc: Dmitry Torokhov, linux-input Am Mittwoch, 30. Juni 2010, 09:16:35 schrieb Petr Štetiar: > Dmitry Torokhov <dmitry.torokhov@gmail.com> [2010-06-28 09:46:03]: > > > Applied to 'next' branch (for .36). But I was wondering - could you > > please try the runtime PM patches to usebtouchscreen posted by Oliver > > Neukum on the linux-input list? I'd really like to apply them but > > I'd like to have them tested first. > > Thank you for applying my patches. Well, I've now only broken touchscreen, > which have only 4-wires or so working, but I think, that it should be enough > for PM testing. What kind of testing do you need, just few suspend & resume > cycles? CC-ing Oliver also. I need 1. indeed a few suspend & resume cycles 2. to know what happens if you switch runtime power management on with echo "auto" >/sys/bus/usb/devices/$DEVICE/power/level Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: usbtouchscreen - runtime PM patches testing [Was: [PATCH 1/2] Input: usbtouchscreen - add support for ET&T TC4UM touchscreen controller] 2010-06-30 13:04 ` Oliver Neukum @ 2010-07-14 10:43 ` Petr Štetiar 2010-07-14 12:23 ` Oliver Neukum 0 siblings, 1 reply; 12+ messages in thread From: Petr Štetiar @ 2010-07-14 10:43 UTC (permalink / raw) To: Oliver Neukum; +Cc: Petr Štetiar, Dmitry Torokhov, linux-input Oliver Neukum <oneukum@suse.de> [2010-06-30 15:04:51]: Hi, > 1. indeed a few suspend & resume cycles it seems to work, although I've tested it with the suspend to RAM only with 'echo devices > /sys/power/pm_test', the complete suspend doesn't work on my laptop. I hope it's enough. If the whole cycle is necessary I can try to test it on I was testing it with 'cat /dev/input/touchscreen | od -x' and without your patches the device dissapeared after the resume cycle. With your patches it was still working fine after 5-6 suspend and resume cycles. > 2. to know what happens if you switch runtime power management on with > echo "auto" >/sys/bus/usb/devices/$DEVICE/power/level Sorry my ignorance, but what should happen? I don't follow PM stuff that much. I've enabled auto and the touchscreen is still working and nothing has changed, is it ok? -- ynezz ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: usbtouchscreen - runtime PM patches testing [Was: [PATCH 1/2] Input: usbtouchscreen - add support for ET&T TC4UM touchscreen controller] 2010-07-14 10:43 ` Petr Štetiar @ 2010-07-14 12:23 ` Oliver Neukum 2010-07-15 6:39 ` Petr Štetiar 0 siblings, 1 reply; 12+ messages in thread From: Oliver Neukum @ 2010-07-14 12:23 UTC (permalink / raw) To: Petr Štetiar; +Cc: Dmitry Torokhov, linux-input Am Mittwoch, 14. Juli 2010, 12:43:27 schrieb Petr Štetiar: > Oliver Neukum <oneukum@suse.de> [2010-06-30 15:04:51]: > > Hi, > > > 1. indeed a few suspend & resume cycles > > it seems to work, although I've tested it with the suspend to RAM only with > 'echo devices > /sys/power/pm_test', the complete suspend doesn't work on my > laptop. I hope it's enough. If the whole cycle is necessary I can try to test > it on > > I was testing it with 'cat /dev/input/touchscreen | od -x' and without your > patches the device dissapeared after the resume cycle. With your patches it was > still working fine after 5-6 suspend and resume cycles. This is enough. Thank you. > > 2. to know what happens if you switch runtime power management on with > > echo "auto" >/sys/bus/usb/devices/$DEVICE/power/level > > Sorry my ignorance, but what should happen? I don't follow PM stuff that much. > I've enabled auto and the touchscreen is still working and nothing has > changed, is it ok? This is quite good already. Ideally in the /sys/bus/usb/devices/$DEVICE/power directory active_duration should grow slower than connected_duration. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: usbtouchscreen - runtime PM patches testing [Was: [PATCH 1/2] Input: usbtouchscreen - add support for ET&T TC4UM touchscreen controller] 2010-07-14 12:23 ` Oliver Neukum @ 2010-07-15 6:39 ` Petr Štetiar 0 siblings, 0 replies; 12+ messages in thread From: Petr Štetiar @ 2010-07-15 6:39 UTC (permalink / raw) To: Oliver Neukum; +Cc: Petr Štetiar, Dmitry Torokhov, linux-input Oliver Neukum <oneukum@suse.de> [2010-07-14 14:23:04]: > This is quite good already. Ideally in the /sys/bus/usb/devices/$DEVICE/power > directory active_duration should grow slower than connected_duration. Yes, it's behaving as you described. -- ynezz ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2010-07-15 6:39 UTC | newest] Thread overview: 12+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <AANLkTimmEtxuQ00jlLPMJkiS7htBV53wMpuWzW_RPs51@mail.gmail.com> [not found] ` <20100603072424.GP26052@ibawizard.net> [not found] ` <20100603075720.GQ26052@ibawizard.net> 2010-06-10 9:33 ` [patch] TC4UM driver for linux-input Roger Pueyo 2010-06-11 7:40 ` [PATCH 1/2] Input: usbtouchscreen - add support for ET&T TC4UM touchscreen controller Petr Štetiar 2010-06-11 7:40 ` [PATCH 2/2] HID: blacklist ET&T TC4UH " Petr Štetiar 2010-06-11 7:55 ` Jiri Kosina 2010-06-28 9:19 ` [PATCH 1/2] Input: usbtouchscreen - add support for ET&T TC4UM " Petr Štetiar 2010-06-28 16:46 ` Dmitry Torokhov 2010-06-30 7:16 ` usbtouchscreen - runtime PM patches testing [Was: [PATCH 1/2] Input: usbtouchscreen - add support for ET&T TC4UM touchscreen controller] Petr Štetiar 2010-06-30 7:48 ` Dmitry Torokhov 2010-06-30 13:04 ` Oliver Neukum 2010-07-14 10:43 ` Petr Štetiar 2010-07-14 12:23 ` Oliver Neukum 2010-07-15 6:39 ` Petr Štetiar
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).