From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 0/4] Current ad7879 patches Date: Wed, 30 Jun 2010 01:03:45 -0700 Message-ID: <20100630080345.GC4154@core.coreip.homeip.net> References: <20100625081847.8617.31150.stgit@localhost.localdomain> <544AC56F16B56944AEC3BD4E3D5917712E66DFF408@LIMKCMBX1.ad.analog.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pz0-f46.google.com ([209.85.210.46]:50648 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751830Ab0F3IDy (ORCPT ); Wed, 30 Jun 2010 04:03:54 -0400 Received: by pzk7 with SMTP id 7so80613pzk.19 for ; Wed, 30 Jun 2010 01:03:52 -0700 (PDT) Content-Disposition: inline In-Reply-To: <544AC56F16B56944AEC3BD4E3D5917712E66DFF408@LIMKCMBX1.ad.analog.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: "Hennerich, Michael" Cc: Mike Frysinger , "linux-input@vger.kernel.org" , "uclinux-dist-devel@blackfin.uclinux.org" On Tue, Jun 29, 2010 at 01:10:38PM +0100, Hennerich, Michael wrote: > Dmitry Torokhov wrote on 2010-06-25: > > Mike, Michael, > > > > I was looking through outstanding patches to ad7879 and here they are. > > Since I made some changes to the patches you wrote and there also some > > new code and I do not have the hardware I'd appreciate if you could > > try them out so they can be applied. > > > > Thank you. > > > > Hi Dmitry, > > I tested your ad7879 patch set - > A few issues see patch below. > > -Fix ad7879_probe() parameter passing. > -Add missing input_set_drvdata() > -Avoid unbalanced irq enable warning: disable_irq() after request. > -Fix sysfs disable hook logic: the file is called disable so don't treat it as enable. > Thanks for catching all the mistakes Michael. Regardgin disable_irq() - do you think it would be even better to call __ad7879_disable() there to make sure the chip is in low power mode? And I guess we need to add matching enable_irq() in error handlig path and in ad7879_remove() in case we reload the driver... BTW, I will be applying the other 2 patches you sent. -- Dmitry