* [PATCH] Input: twl4030-pwrbutton - replace __devinit with __init
@ 2010-07-07 13:24 Markus Lehtonen
2010-07-08 9:27 ` Felipe Balbi
2010-07-14 16:31 ` Dmitry Torokhov
0 siblings, 2 replies; 3+ messages in thread
From: Markus Lehtonen @ 2010-07-07 13:24 UTC (permalink / raw)
To: linux-input; +Cc: dtor, felipe.balbi
Power button is not hot-pluggable so we can save some memory by
using __init.
Signed-off-by: Markus Lehtonen <markus.lehtonen@nokia.com>
---
drivers/input/misc/twl4030-pwrbutton.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbutton.c
index e9069b8..353cfea 100644
--- a/drivers/input/misc/twl4030-pwrbutton.c
+++ b/drivers/input/misc/twl4030-pwrbutton.c
@@ -52,7 +52,7 @@ static irqreturn_t powerbutton_irq(int irq, void *_pwr)
return IRQ_HANDLED;
}
-static int __devinit twl4030_pwrbutton_probe(struct platform_device *pdev)
+static int __init twl4030_pwrbutton_probe(struct platform_device *pdev)
{
struct input_dev *pwr;
int irq = platform_get_irq(pdev, 0);
@@ -107,7 +107,6 @@ static int __devexit twl4030_pwrbutton_remove(struct platform_device *pdev)
}
struct platform_driver twl4030_pwrbutton_driver = {
- .probe = twl4030_pwrbutton_probe,
.remove = __devexit_p(twl4030_pwrbutton_remove),
.driver = {
.name = "twl4030_pwrbutton",
@@ -117,7 +116,8 @@ struct platform_driver twl4030_pwrbutton_driver = {
static int __init twl4030_pwrbutton_init(void)
{
- return platform_driver_register(&twl4030_pwrbutton_driver);
+ return platform_driver_probe(&twl4030_pwrbutton_driver,
+ twl4030_pwrbutton_probe);
}
module_init(twl4030_pwrbutton_init);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Input: twl4030-pwrbutton - replace __devinit with __init
2010-07-07 13:24 [PATCH] Input: twl4030-pwrbutton - replace __devinit with __init Markus Lehtonen
@ 2010-07-08 9:27 ` Felipe Balbi
2010-07-14 16:31 ` Dmitry Torokhov
1 sibling, 0 replies; 3+ messages in thread
From: Felipe Balbi @ 2010-07-08 9:27 UTC (permalink / raw)
To: Lehtonen Markus (Nokia-MS/Helsinki)
Cc: linux-input@vger.kernel.org, dtor@mail.ru,
Balbi Felipe (Nokia-MS/Helsinki)
On Wed, Jul 07, 2010 at 03:24:23PM +0200, Lehtonen Markus (Nokia-MS/Helsinki) wrote:
>Power button is not hot-pluggable so we can save some memory by
>using __init.
>
>Signed-off-by: Markus Lehtonen <markus.lehtonen@nokia.com>
then you need to change __devexit too ?!?
--
balbi
DefectiveByDesign.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: twl4030-pwrbutton - replace __devinit with __init
2010-07-07 13:24 [PATCH] Input: twl4030-pwrbutton - replace __devinit with __init Markus Lehtonen
2010-07-08 9:27 ` Felipe Balbi
@ 2010-07-14 16:31 ` Dmitry Torokhov
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2010-07-14 16:31 UTC (permalink / raw)
To: Markus Lehtonen; +Cc: linux-input, felipe.balbi
On Wed, Jul 07, 2010 at 04:24:23PM +0300, Markus Lehtonen wrote:
> Power button is not hot-pluggable so we can save some memory by
> using __init.
>
> Signed-off-by: Markus Lehtonen <markus.lehtonen@nokia.com>
Applied to next, thanks Markus.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-07-14 16:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-07 13:24 [PATCH] Input: twl4030-pwrbutton - replace __devinit with __init Markus Lehtonen
2010-07-08 9:27 ` Felipe Balbi
2010-07-14 16:31 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).