From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Alan Cox <alan@linux.intel.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] cy8ctmg110: capacitive touchscreen support
Date: Fri, 9 Jul 2010 09:28:46 -0700 [thread overview]
Message-ID: <20100709162846.GC19827@core.coreip.homeip.net> (raw)
In-Reply-To: <20100709162704.GB19827@core.coreip.homeip.net>
On Fri, Jul 09, 2010 at 09:27:05AM -0700, Dmitry Torokhov wrote:
> On Fri, Jul 09, 2010 at 04:36:32PM +0100, Alan Cox wrote:
> > From: Samuli Konttila <samuli.konttila@aavamobile.com>
> >
> > Add support for the cy8ctmg110 capacitive touchscreen used on some embedded
> > devices.
> >
> > (Some clean up by Alan Cox)
> >
> > - Moved the hardcoded GPIO lines into platform data
> >
>
> I still see GPIO lines hardcoded. Wrong changeset description?
>
> > +
> > + hrtimer_init(&ts->timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
> > + ts->timer.function = cy8ctmg110_timer;
> > +
>
> I doubt it compiles since you seem to have removed cy8ctmg110_timer().
>
Ah, see you sent the next version, ignore me then.
--
Dmitry
next prev parent reply other threads:[~2010-07-09 16:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-09 15:36 [PATCH] cy8ctmg110: capacitive touchscreen support Alan Cox
2010-07-09 16:27 ` Dmitry Torokhov
2010-07-09 16:28 ` Dmitry Torokhov [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-07-09 15:53 Alan Cox
2010-07-09 16:59 ` Dmitry Torokhov
2010-07-09 16:48 ` Alan Cox
2010-07-08 16:11 Alan Cox
2010-07-08 17:26 ` Dmitry Torokhov
2010-07-09 14:13 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100709162846.GC19827@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=alan@linux.intel.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).