* [PATCH] input: fix uninitialized old_keycode oops in input_set_keycode
@ 2010-07-19 19:59 Jarod Wilson
0 siblings, 0 replies; only message in thread
From: Jarod Wilson @ 2010-07-19 19:59 UTC (permalink / raw)
To: linux-media; +Cc: linux-input, kmcmartin
Patch as suggested by Kyle McMartin, in response to Red Hat bugzilla
615707, filed against a rawhide kernel carrying ir-core enabling patches
from the linuxtv staging/other tree. Fix is based on the similar logic in
input_set_keycode_big, and is confirmed by the bz reporter.
CC: Kyle McMartin <kmcmartin@redhat.com>
Signed-off-by: Jarod Wilson <jarod@redhat.com>
---
drivers/input/input.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/input/input.c b/drivers/input/input.c
index ce5d90d..0c71977 100644
--- a/drivers/input/input.c
+++ b/drivers/input/input.c
@@ -900,6 +900,7 @@ int input_set_keycode(struct input_dev *dev,
if (retval)
goto out;
+ old_keycode = kt_entry.keycode;
kt_entry.keycode = keycode;
retval = dev->setkeycodebig(dev, &kt_entry);
--
1.7.1.1
--
Jarod Wilson
jarod@redhat.com
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-07-19 20:08 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-19 19:59 [PATCH] input: fix uninitialized old_keycode oops in input_set_keycode Jarod Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).