linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Xiaolong Chen <xiaolong.chen@gmail.com>
Cc: Michael <Michael.Hennerich@analog.com>,
	david-b@pacbell.net,
	Michael Hennerich <hennerich@blackfin.uclinux.org>,
	linux-input@vger.kernel.org, TAO HU <taohu@motorola.com>,
	"Yuan.Bo YE" <yuan-bo.ye@motorola.com>,
	Xiaolong CHEN <a21785@motorola.com>
Subject: Re: Fwd: [RFC] [PATCH] Input: ADP5588 - Support gpio function on unused pin
Date: Tue, 20 Jul 2010 11:40:03 -0700	[thread overview]
Message-ID: <20100720184003.GA14222@core.coreip.homeip.net> (raw)
In-Reply-To: <4c459b70.0aee8c0a.1c29.3e9e@mx.google.com>

Hi Xiaolong,

On Tue, Jul 20, 2010 at 08:49:36PM +0800, Xiaolong Chen wrote:
> Hi Dmitry,
> 
> There is still some issue on my company mail system, so change to this mail to submit the patch.
> 
> Looks like this time haven't the line wrapped issue, any further comments and suggestion, please let me know.
> 

I think we need to protect the code you are adding with #ifdef
CONFIG_GPIOLIBi and provide the stubs in case gpiolib is not
available. This will also force splitting the gpio hanlding code
into separate functions so that it is easier to read. Please see
how it is done in ad7879 driver.

Also if would be great if you generated the patch against the
version of the driver that is ither in linux-next or in the 'next'
branch of my tree as there a few changes clashing with yours.

Thanks.

-- 
Dmitry

       reply	other threads:[~2010-07-20 18:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4c459b70.0aee8c0a.1c29.3e9e@mx.google.com>
2010-07-20 18:40 ` Dmitry Torokhov [this message]
2010-07-26 15:45 ` Fwd: [RFC] [PATCH] Input: ADP5588 - Support gpio function on unused pin Xiaolong Chen
2010-07-26 17:38   ` Dmitry Torokhov
2010-07-27  5:31     ` Xiaolong Chen
     [not found]       ` <AANLkTi=qHUknGZdoj75Nr9gCKe-TRPMf3cgtsHejSrOc-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-07-30  8:29         ` Hennerich, Michael
2010-07-30 17:08           ` Dmitry Torokhov
     [not found]             ` <20100730170854.GA22450-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2010-08-02  9:37               ` Hennerich, Michael

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100720184003.GA14222@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=a21785@motorola.com \
    --cc=david-b@pacbell.net \
    --cc=hennerich@blackfin.uclinux.org \
    --cc=linux-input@vger.kernel.org \
    --cc=taohu@motorola.com \
    --cc=xiaolong.chen@gmail.com \
    --cc=yuan-bo.ye@motorola.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).