From: Samuel Ortiz <sameo@linux.intel.com>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Luotao Fu <l.fu@pengutronix.de>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/8] touchscreen: fix sign bug
Date: Sun, 25 Jul 2010 23:32:41 +0200 [thread overview]
Message-ID: <20100725213240.GA2613@sortiz-mobl> (raw)
In-Reply-To: <1279219435-12128-1-git-send-email-segooon@gmail.com>
Hi Vasiliy,
On Thu, Jul 15, 2010 at 10:43:54PM +0400, Kulikov Vasiliy wrote:
> platform_get_irq_byname() can return negative results, it is not seen to
> unsigned ts_irq. Make it signed.
Patch applied to my mfd tree, thanks.
Cheers,
Samuel.
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
> ---
> drivers/input/touchscreen/stmpe-ts.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscreen/stmpe-ts.c
> index 77f4374..656148e 100644
> --- a/drivers/input/touchscreen/stmpe-ts.c
> +++ b/drivers/input/touchscreen/stmpe-ts.c
> @@ -269,7 +269,7 @@ static int __devinit stmpe_input_probe(struct platform_device *pdev)
> struct input_dev *idev;
> struct stmpe_ts_platform_data *ts_pdata = NULL;
> int ret = 0;
> - unsigned int ts_irq;
> + int ts_irq;
>
> ts_irq = platform_get_irq_byname(pdev, "FIFO_TH");
> if (ts_irq < 0)
> --
> 1.7.0.4
>
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2010-07-25 21:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 18:43 [PATCH 2/8] touchscreen: fix sign bug Kulikov Vasiliy
2010-07-15 20:49 ` Luotao Fu
2010-07-16 7:18 ` Dmitry Torokhov
2010-07-25 21:32 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100725213240.GA2613@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=l.fu@pengutronix.de \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=segooon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).