From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: Tony Lindgren <tony@atomide.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Amit Kucheria <amit.kucheria@verdurent.com>,
linux-input@vger.kernel.org, linux-omap@vger.kernel.org,
stable@kernel.org
Subject: Re: [PATCH] Input: OMAP: RX51: fix 'KEY_10' compile breakage
Date: Tue, 27 Jul 2010 09:43:25 -0700 [thread overview]
Message-ID: <20100727164325.GA4302@core.coreip.homeip.net> (raw)
In-Reply-To: <alpine.DEB.2.00.1007261625470.1906@utopia.booyaka.com>
Hi Paul,
On Mon, Jul 26, 2010 at 04:28:12PM -0600, Paul Walmsley wrote:
>
> Commit 3fea60261e73dbf4a51130d40cafcc8465b0f2c3 replaces KEY_F10 and
> KEY_F11 macro references with 'KEY_10' and 'KEY_11'. This breaks
> v2.6.35-rc6 compiles with omap3_defconfig:
>
> CC arch/arm/mach-omap2/board-rx51-peripherals.o
> arch/arm/mach-omap2/board-rx51-peripherals.c:223: error: 'KEY_10' undeclared here (not in a function)
> arch/arm/mach-omap2/board-rx51-peripherals.c:226: error: 'KEY_11' undeclared here (not in a function)
>
> Fix by renaming the macro references back to KEY_F10 and KEY_F11.
>
> Compile-tested only.
>
Thank you for the patch however Linus managed to fish off LKML and apply
another version that I posted earlier.
--
Dmitry
prev parent reply other threads:[~2010-07-27 16:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-26 22:28 [PATCH] Input: OMAP: RX51: fix 'KEY_10' compile breakage Paul Walmsley
2010-07-27 16:43 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100727164325.GA4302@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=amit.kucheria@verdurent.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=stable@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).