From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [PATCH 1/9] IR: Kconfig fixes Date: Wed, 28 Jul 2010 10:36:17 -0700 Message-ID: <20100728103617.4b0207b9.randy.dunlap@oracle.com> References: <1280330051-27732-1-git-send-email-maximlevitsky@gmail.com> <1280330051-27732-2-git-send-email-maximlevitsky@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from rcsinet10.oracle.com ([148.87.113.121]:27338 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751303Ab0G1Rhl (ORCPT ); Wed, 28 Jul 2010 13:37:41 -0400 In-Reply-To: <1280330051-27732-2-git-send-email-maximlevitsky@gmail.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Maxim Levitsky Cc: lirc-list@lists.sourceforge.net, Jarod Wilson , linux-input@vger.kernel.org, linux-media@vger.kernel.org, Mauro Carvalho Chehab On Wed, 28 Jul 2010 18:14:03 +0300 Maxim Levitsky wrote: > Move IR drives below separate menu. > This allows to disable them. > Also correct a typo. > > Signed-off-by: Maxim Levitsky > --- > drivers/media/IR/Kconfig | 14 +++++++++++--- > 1 files changed, 11 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/IR/Kconfig b/drivers/media/IR/Kconfig > index e557ae0..99ea9cd 100644 > --- a/drivers/media/IR/Kconfig > +++ b/drivers/media/IR/Kconfig > @@ -1,8 +1,10 @@ > -config IR_CORE > - tristate > +menuconfig IR_CORE > + tristate "Infrared remote controller adapters" > depends on INPUT > default INPUT > > +if IR_CORE > + > config VIDEO_IR > tristate > depends on IR_CORE > @@ -16,7 +18,7 @@ config LIRC > Enable this option to build the Linux Infrared Remote > Control (LIRC) core device interface driver. The LIRC > interface passes raw IR to and from userspace, where the > - LIRC daemon handles protocol decoding for IR reception ann > + LIRC daemon handles protocol decoding for IR reception and > encoding for IR transmitting (aka "blasting"). > > source "drivers/media/IR/keymaps/Kconfig" > @@ -102,3 +104,9 @@ config IR_MCEUSB > > To compile this driver as a module, choose M here: the > module will be called mceusb. > + > + > + > + > + > +endif #IR_CORE I don't think that those extra blank lines are a fix... --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***