From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Mike Auty <ikelos@gentoo.org>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH 2.6.35.3] wacom: Fix mousewheel up/down regression for old wacom tablets
Date: Sat, 28 Aug 2010 21:40:57 -0700 [thread overview]
Message-ID: <20100829044057.GA15369@core.coreip.homeip.net> (raw)
In-Reply-To: <4C755C78.4000801@gentoo.org>
On Wed, Aug 25, 2010 at 07:10:00PM +0100, Mike Auty wrote:
> This fixes a regression introduced in
> 3b57ca0f80c5c8994b5b1e3d3f904cfe727951f2.
>
> The data[6] byte contains either 1 or -1 depending on the whether the
> mouse wheel on older wacom tablets is moved down (1) or up (-1). The
> patch introduced in the above commit changed the cast from (signed char)
> to (signed). When cast as a signed integer and negated, the value of -1
> (stored in the byte as 0xff) became -255 rather than 1. This patch
> reverts the cast to a (signed char) and also removes an unnecessary
> (signed) cast, as all the values operated on are bitmasked.
>
> Signed-off-by: Mike Auty <ikelos@gentoo.org>
> Reviewed-by: Ping Cheng <pingc@wacom.com>
Applied, thank you Mike.
--
Dmitry
prev parent reply other threads:[~2010-08-29 4:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 18:10 [PATCH 2.6.35.3] wacom: Fix mousewheel up/down regression for old wacom tablets Mike Auty
2010-08-29 4:40 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100829044057.GA15369@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=ikelos@gentoo.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).