* Input: tps6507x-ts - add missing platform_set_drvdata() in tps6507x_ts_probe()
@ 2010-09-02 9:20 Axel Lin
2010-09-02 15:55 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2010-09-02 9:20 UTC (permalink / raw)
To: linux-kernel; +Cc: Todd Fischer, Dmitry Torokhov, linux-input
We call platform_get_drvdata() in tps6507x_ts_remove(),
thus we should call platform_set_drvdata() in tps6507x_ts_probe().
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/input/touchscreen/tps6507x-ts.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/input/touchscreen/tps6507x-ts.c b/drivers/input/touchscreen/tps6507x-ts.c
index a644d18..7286209 100644
--- a/drivers/input/touchscreen/tps6507x-ts.c
+++ b/drivers/input/touchscreen/tps6507x-ts.c
@@ -335,6 +335,7 @@ static int tps6507x_ts_probe(struct platform_device *pdev)
dev_err(tsc->dev, "schedule failed");
goto err2;
}
+ platform_set_drvdata(pdev, tps6507x_dev);
return 0;
--
1.7.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: Input: tps6507x-ts - add missing platform_set_drvdata() in tps6507x_ts_probe()
2010-09-02 9:20 Input: tps6507x-ts - add missing platform_set_drvdata() in tps6507x_ts_probe() Axel Lin
@ 2010-09-02 15:55 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2010-09-02 15:55 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Todd Fischer, linux-input
On Thu, Sep 02, 2010 at 05:20:41PM +0800, Axel Lin wrote:
> We call platform_get_drvdata() in tps6507x_ts_remove(),
> thus we should call platform_set_drvdata() in tps6507x_ts_probe().
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Applied, thanks Axel.
> ---
> drivers/input/touchscreen/tps6507x-ts.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/input/touchscreen/tps6507x-ts.c b/drivers/input/touchscreen/tps6507x-ts.c
> index a644d18..7286209 100644
> --- a/drivers/input/touchscreen/tps6507x-ts.c
> +++ b/drivers/input/touchscreen/tps6507x-ts.c
> @@ -335,6 +335,7 @@ static int tps6507x_ts_probe(struct platform_device *pdev)
> dev_err(tsc->dev, "schedule failed");
> goto err2;
> }
> + platform_set_drvdata(pdev, tps6507x_dev);
>
> return 0;
>
> --
> 1.7.2
>
>
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-02 15:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-02 9:20 Input: tps6507x-ts - add missing platform_set_drvdata() in tps6507x_ts_probe() Axel Lin
2010-09-02 15:55 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).