From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Eric Millbrandt <emillbrandt@dekaresearch.com>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: [RFC] Input: wm97xx-core - Remove save state from wm97xx_read_aux_adc()
Date: Thu, 2 Sep 2010 17:16:01 +0100 [thread overview]
Message-ID: <20100902161600.GF5809@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <0A40042D85E7C84DB443060EC44B3FD3254AA09E84@dekaexchange07.deka.local>
On Thu, Sep 02, 2010 at 11:32:29AM -0400, Eric Millbrandt wrote:
> It does. So I will modify wm97xx_read_aux_adc() to do the following:
> -Call poll_sample()
> -If the return value is not RC_VALID call poll_sample() again
> -If after 5 tries (I'm not sure how many samples can be queued) we have
> not succeeded, stop the digitizer and return -1.
> -Otherwise return auxadc.
> If this sounds reasonable I will create a patch for review.
Yup. I'd return -EBUSY or something rather than a made up error code.
5 seems like a reasonable number of times to try.
prev parent reply other threads:[~2010-09-02 16:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-01 14:52 [RFC] Input: wm97xx-core - Remove save state from wm97xx_read_aux_adc() Eric Millbrandt
2010-09-01 17:19 ` Mark Brown
2010-09-01 18:46 ` Eric Millbrandt
2010-09-01 18:46 ` Mark Brown
2010-09-01 19:17 ` Eric Millbrandt
2010-09-02 14:40 ` Mark Brown
2010-09-02 15:32 ` Eric Millbrandt
2010-09-02 16:16 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100902161600.GF5809@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=emillbrandt@dekaresearch.com \
--cc=linux-input@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).