From mboxrd@z Thu Jan 1 00:00:00 1970 From: David =?iso-8859-1?Q?H=E4rdeman?= Subject: Re: [PATCH 6/7] IR: extend ir_raw_event and do refactoring Date: Thu, 2 Sep 2010 22:56:07 +0200 Message-ID: <20100902205607.GB3886@hardeman.nu> References: <1283158348-7429-1-git-send-email-maximlevitsky@gmail.com> <1283158348-7429-7-git-send-email-maximlevitsky@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from 1-1-12-13a.han.sth.bostream.se ([82.182.30.168]:45711 "EHLO palpatine.hardeman.nu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754889Ab0IBU4L (ORCPT ); Thu, 2 Sep 2010 16:56:11 -0400 Content-Disposition: inline In-Reply-To: <1283158348-7429-7-git-send-email-maximlevitsky@gmail.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Maxim Levitsky Cc: lirc-list@lists.sourceforge.net, Jarod Wilson , linux-input@vger.kernel.org, linux-media@vger.kernel.org, Mauro Carvalho Chehab , Christoph Bartelmus On Mon, Aug 30, 2010 at 11:52:26AM +0300, Maxim Levitsky wrote: > Add new event types for timeout & carrier report > Move timeout handling from ir_raw_event_store_with_filter to > ir-lirc-codec, where it is really needed. Yes, but it still might make more sense to keep the timeout handling in= =20 ir_raw_event_store_with_filter so that all decoders get the same data=20 from rc-core? > Now lirc bridge ensures proper gap handling. > Extend lirc bridge for carrier & timeout reports >=20 > Note: all new ir_raw_event variables now should be initialized > like that: > struct ir_raw_event ev =3D ir_new_event; Wouldn't DEFINE_RAW_EVENT(ev); be more in line with the kernel coding=20 style? (cf. DEFINE_MUTEX, DEFINE_SPINLOCK, etc). --=20 David H=E4rdeman -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html