From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Igor Grinberg <grinberg@compulab.co.il>
Cc: "Premi, Sanjeev" <premi@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: omap3: regulator_get() failure in ads7846
Date: Tue, 7 Sep 2010 13:51:19 +0100 [thread overview]
Message-ID: <20100907125118.GC25830@sirena.org.uk> (raw)
In-Reply-To: <4C862D15.1070606@compulab.co.il>
On Tue, Sep 07, 2010 at 03:16:21PM +0300, Igor Grinberg wrote:
> I think, this can help:
> http://www.spinics.net/lists/arm-kernel/msg94759.html
> Seems like there were not enough interest and it is still floating.
> May be a little ping can help ;)
This is a really bad idea unless the supplies genuinely are optional -
we shouldn't be doing this sort of bodge in the drivers, that's just
going to lead to lots of repetitive code adding complexity every time
the regulator API is used. It also makes the error handling rather more
obscure since systems that genuinely need the regulator won't be
reporting problems clearly.
The regulator API has facilties on several levels to deal with systems
that have problems here: it provides fixed voltage regulators, it
provides the option to substitute in dummy regulators automatically and
if the regulator API is disabled then the stub functions provided will
report success.
next prev parent reply other threads:[~2010-09-07 12:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-07 11:46 omap3: regulator_get() failure in ads7846 Premi, Sanjeev
2010-09-07 11:56 ` Mark Brown
2010-09-07 13:26 ` Premi, Sanjeev
2010-09-07 14:18 ` Mark Brown
2010-09-07 12:16 ` Igor Grinberg
2010-09-07 12:51 ` Mark Brown [this message]
2010-09-07 12:53 ` Premi, Sanjeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100907125118.GC25830@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=grinberg@compulab.co.il \
--cc=linux-input@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=premi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).