From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Trilok Soni <tsoni@codeaurora.org>
Cc: Naveen Kumar GADDIPATI <naveen.gaddipati@stericsson.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
STEricsson_nomadik_linux <STEricsson_nomadik_linux@list.st.com>
Subject: Re: [Patch v2] input:rohm based bu21013 touch panel controller driver support
Date: Thu, 9 Sep 2010 08:39:30 -0700 [thread overview]
Message-ID: <20100909153930.GA19937@core.coreip.homeip.net> (raw)
In-Reply-To: <4C88E52B.3020107@codeaurora.org>
On Thu, Sep 09, 2010 at 07:16:19PM +0530, Trilok Soni wrote:
> On 9/9/2010 6:50 PM, Naveen Kumar GADDIPATI wrote:
> > Hi Trilok,
> >
> >> -----Original Message-----
> >> From: Trilok Soni [mailto:tsoni@codeaurora.org]
> >> Sent: Thursday, September 09, 2010 5:41 PM
> >> To: Naveen Kumar GADDIPATI
> >> Cc: Dmitry Torokhov; linux-input@vger.kernel.org;
> >> STEricsson_nomadik_linux
> >
> >
> >>> +
> >>> +static struct i2c_driver bu21013_driver = {
> >>> + .driver = {
> >>> + .name = DRIVER_TP,
> >>> + .owner = THIS_MODULE,
> >>> + },
> >>> + .probe = bu21013_probe,
> >>> +#ifdef CONFIG_PM
> >>> + .suspend = bu21013_suspend,
> >>> + .resume = bu21013_resume,
> >>> +#endif
> >>
> >> Better to move these suspend and resume to dev_pm_ops.
> >>
> > How we could dev_pm_ops in i2c driver structure?
> >
>
> Refer: drivers/input/keyboard/adp5588-keys.c as example.
>
Hm, indeed I forgot that i2c has been fully wired for dev_pm_ops. I
should enforce its use then. Thank you for reminding Trilok.
I wonder if someone could wire SPI as well...
--
Dmitry
next prev parent reply other threads:[~2010-09-09 15:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-09 11:36 [Patch v2] input:rohm based bu21013 touch panel controller driver support Naveen Kumar GADDIPATI
2010-09-09 12:10 ` Trilok Soni
2010-09-09 13:20 ` Naveen Kumar GADDIPATI
2010-09-09 13:46 ` Trilok Soni
2010-09-09 15:39 ` Dmitry Torokhov [this message]
2010-09-09 18:44 ` Trilok Soni
2010-09-09 15:59 ` Dmitry Torokhov
2010-09-09 16:01 ` Dmitry Torokhov
2010-09-09 18:26 ` Henrik Rydberg
2010-09-13 10:12 ` Naveen Kumar GADDIPATI
2010-09-13 14:36 ` Henrik Rydberg
-- strict thread matches above, loose matches on Subject: below --
2010-09-09 12:12 Naveen Kumar GADDIPATI
2010-09-09 12:13 ` Trilok Soni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100909153930.GA19937@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=STEricsson_nomadik_linux@list.st.com \
--cc=linux-input@vger.kernel.org \
--cc=naveen.gaddipati@stericsson.com \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).