From: Oliver Neukum <oliver@neukum.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-pm@lists.linux-foundation.org, pingc@wacom.com,
Jiri Slaby <jslaby@suse.cz>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>,
linux-input@vger.kernel.org
Subject: Re: [linux-pm] wacom + runtime PM = AA deadlock
Date: Tue, 14 Sep 2010 08:07:39 +0200 [thread overview]
Message-ID: <201009140807.39977.oliver@neukum.org> (raw)
In-Reply-To: <20100914005209.GB27540@core.coreip.homeip.net>
Am Dienstag, 14. September 2010, 02:52:10 schrieb Dmitry Torokhov:
> On Mon, Sep 13, 2010 at 09:20:23PM +0200, Oliver Neukum wrote:
> > Am Montag, 13. September 2010, 19:10:47 schrieb Dmitry Torokhov:
> >
> > > I think this introduces significant change in behavior though - before
> > > we did not do usb_autopm_put_interface() on successful open, basically
> > > disabling autopm facilities, right?
> >
> > Right. Which makes no sense at all. You'd better remove anything related
> > to runtime PM and not set supports_autosuspend for that.
> >
>
> That not what I meant, I do not want to remove autopm, it's just it was
> effectively disabled and if we fix it we might start getting some
> regression reports ;)
True. So currently we have
- a deadlock
- disabled runtime power management
We need to fix the deadlock. We can fix it retaining a disabled
runtime power management. Or we can fix it fixing the runtime
power management at the same time. However this opens
the door to regressions. So for now I really suggest removing
it from the driver and reintroduce it properly for the next merge
window.
Regards
Oliver
next prev parent reply other threads:[~2010-09-14 6:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-13 12:24 wacom + runtime PM = AA deadlock Jiri Slaby
2010-09-13 14:25 ` [linux-pm] " Alan Stern
2010-09-13 14:56 ` Oliver Neukum
2010-09-13 15:17 ` [linux-pm] " Alan Stern
2010-09-13 19:05 ` Oliver Neukum
2010-09-13 20:02 ` Alan Stern
2010-09-13 20:28 ` Dmitry Torokhov
2010-09-14 8:13 ` Oliver Neukum
2010-09-14 14:01 ` Alan Stern
2010-09-14 14:03 ` Oliver Neukum
2010-09-14 15:23 ` Alan Stern
2010-09-14 15:30 ` Oliver Neukum
2010-09-14 16:05 ` Alan Stern
2010-09-13 17:10 ` Dmitry Torokhov
2010-09-13 19:20 ` [linux-pm] " Oliver Neukum
2010-09-14 0:52 ` Dmitry Torokhov
2010-09-14 6:07 ` Oliver Neukum [this message]
2010-10-04 16:13 ` Dmitry Torokhov
2010-10-04 18:33 ` Oliver Neukum
2010-10-04 18:38 ` Dmitry Torokhov
2010-10-04 19:24 ` Oliver Neukum
2010-10-05 5:41 ` Dmitry Torokhov
2010-10-05 5:54 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009140807.39977.oliver@neukum.org \
--to=oliver@neukum.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=pingc@wacom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).