From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 5/6] Input: ati-remote2 - switch to using new keycode interface Date: Wed, 15 Sep 2010 14:13:37 -0700 Message-ID: <20100915211337.GA12119@core.coreip.homeip.net> References: <20100908073233.32365.74621.stgit@hammer.corenet.prv> <20100908074205.32365.68835.stgit@hammer.corenet.prv> <20100909124003.GT10135@sci.fi> <20100913162807.GA14598@core.coreip.homeip.net> <20100915210419.GA6052@sci.fi> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20100915210419.GA6052@sci.fi> Sender: linux-media-owner@vger.kernel.org To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: Mauro Carvalho Chehab , Linux Input , linux-media@vger.kernel.org, Jarod Wilson , Maxim Levitsky , David Hardeman , Jiri Kosina List-Id: linux-input@vger.kernel.org On Thu, Sep 16, 2010 at 12:04:19AM +0300, Ville Syrj=E4l=E4 wrote: > On Mon, Sep 13, 2010 at 09:28:07AM -0700, Dmitry Torokhov wrote: > > On Thu, Sep 09, 2010 at 03:40:04PM +0300, Ville Syrj=E4l=E4 wrote: > > > On Wed, Sep 08, 2010 at 12:42:05AM -0700, Dmitry Torokhov wrote: > > > > Switch the code to use new style of getkeycode and setkeycode > > > > methods to allow retrieving and setting keycodes not only by > > > > their scancodes but also by index. > > > >=20 > > > > Signed-off-by: Dmitry Torokhov > > > > --- > > > >=20 > > > > drivers/input/misc/ati_remote2.c | 93 ++++++++++++++++++++++= +++++----------- > > > > 1 files changed, 65 insertions(+), 28 deletions(-) > > > >=20 > > > > diff --git a/drivers/input/misc/ati_remote2.c b/drivers/input/m= isc/ati_remote2.c > > > > index 2325765..b2e0d82 100644 > > > > --- a/drivers/input/misc/ati_remote2.c > > > > +++ b/drivers/input/misc/ati_remote2.c > > > > @@ -483,51 +483,88 @@ static void ati_remote2_complete_key(stru= ct urb *urb) > > > > } > > > > =20 > > > > static int ati_remote2_getkeycode(struct input_dev *idev, > > > > - unsigned int scancode, unsigned int *keycode) > > > > + struct input_keymap_entry *ke) > > > > { > > > > struct ati_remote2 *ar2 =3D input_get_drvdata(idev); > > > > unsigned int mode; > > > > - int index; > > > > + int offset; > > > > + unsigned int index; > > > > + unsigned int scancode; > > > > + > > > > + if (ke->flags & INPUT_KEYMAP_BY_INDEX) { > > > > + index =3D ke->index; > > > > + if (index >=3D (ATI_REMOTE2_MODES - 1) * > > > ^^^^ > > > That -1 looks wrong. Same in setkeycode(). > > >=20 > >=20 > > Yes, indeed. Thanks for noticing. >=20 > I fixed this bug locally and gave this a short whirl with my RWII. > I tried both the old and new style keycode ioctls. Everything > worked as expected. >=20 > So if you want more tags feel free to add my Acked-by and Tested-by > for this (assuming the off-by-one fix is included) Thank you very much for reviewing and testing it Ville, I will surely add the tags. and you can add my > Tested-by for patch 1/6 as well. >=20 This one is already in public branch; I prefer not to rewind unless there are compile or other major issues.... --=20 Dmitry