From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Henrik Rydberg <rydberg@euromail.se>
Cc: Jiri Kosina <jkosina@suse.cz>, Stephane Chatty <chatty@enac.fr>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hid: 3m: Output proper orientation range
Date: Sun, 19 Sep 2010 16:23:44 -0700 [thread overview]
Message-ID: <20100919232343.GA6565@core.coreip.homeip.net> (raw)
In-Reply-To: <1284886583-30965-1-git-send-email-rydberg@euromail.se>
On Sun, Sep 19, 2010 at 10:56:23AM +0200, Henrik Rydberg wrote:
> The range of orientation values for height/width devices should
> be [0, 1], but is currently set to [1, 1]. Having min == max also
> breaks uinput device setup. Fixed with this patch.
>
> Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
Makes sense.
Acked-by: Dmitry Torokhov <dtor@mail.ru>
> ---
> drivers/hid/hid-3m-pct.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hid/hid-3m-pct.c b/drivers/hid/hid-3m-pct.c
> index cd4b125..860d47c 100644
> --- a/drivers/hid/hid-3m-pct.c
> +++ b/drivers/hid/hid-3m-pct.c
> @@ -110,7 +110,7 @@ static int mmm_input_mapping(struct hid_device *hdev, struct hid_input *hi,
> input_set_abs_params(hi->input, ABS_MT_TOUCH_MINOR,
> f1, f2, df / SN_WIDTH, 0);
> input_set_abs_params(hi->input, ABS_MT_ORIENTATION,
> - 1, 1, 0, 0);
> + 0, 1, 0, 0);
> return 1;
> case HID_DG_CONTACTID:
> field->logical_maximum = MAX_TRKID;
> --
> 1.7.1
>
--
Dmitry
next prev parent reply other threads:[~2010-09-19 23:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-19 8:56 [PATCH] hid: 3m: Output proper orientation range Henrik Rydberg
2010-09-19 23:23 ` Dmitry Torokhov [this message]
2010-09-21 14:15 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100919232343.GA6565@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=chatty@enac.fr \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).