From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Cyril Chemparathy <cyril@ti.com>
Cc: linux-input@vger.kernel.org,
davinci-linux-open-source@linux.davincidsp.com,
shubhrajyoti@ti.com, khilman@deeprootsystems.com
Subject: Re: [PATCH v3 1/5] input: add driver for tnetv107x on-chip keypad controller
Date: Mon, 20 Sep 2010 08:29:35 -0700 [thread overview]
Message-ID: <20100920152935.GA698@core.coreip.homeip.net> (raw)
In-Reply-To: <1284995252-23337-2-git-send-email-cyril@ti.com>
Hi Cyril,
On Mon, Sep 20, 2010 at 11:07:28AM -0400, Cyril Chemparathy wrote:
> This patch adds support for tnetv107x's on-chip keypad controller.
>
There is one thing that I missed - since you have 2 separate irqs they
may execute at the same time on 2 different CPUs (theoretically, if
platform will ever have multiple CPUs) so you need to take a spinlock
inside the interrupt handler to protect from simultaneous access to
shared data.
Once you add it please add
Acked-by: Dmitry Torokhov <dtor@mail.ru>
and forward it to Kevin so it is merged through his tree.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2010-09-20 15:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-20 15:07 [PATCH v3 0/5] add tnetv107x input drivers Cyril Chemparathy
2010-09-20 15:07 ` [PATCH v3 1/5] input: add driver for tnetv107x on-chip keypad controller Cyril Chemparathy
2010-09-20 15:29 ` Dmitry Torokhov [this message]
2010-09-20 15:07 ` [PATCH v3 2/5] davinci: add tnetv107x keypad platform device Cyril Chemparathy
2010-09-20 15:07 ` [PATCH v3 3/5] davinci: add keypad config for tnetv107x evm board Cyril Chemparathy
2010-09-20 15:07 ` [PATCH v3 4/5] input: add driver for tnetv107x touchscreen controller Cyril Chemparathy
2010-09-20 15:31 ` Dmitry Torokhov
2010-09-20 15:07 ` [PATCH v3 5/5] davinci: add tnetv107x touchscreen platform device Cyril Chemparathy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100920152935.GA698@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=cyril@ti.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-input@vger.kernel.org \
--cc=shubhrajyoti@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).